Skip to content

⚠️ Change all *metav1.Time fields to metav1.Time #12518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2025
Merged

⚠️ Change all *metav1.Time fields to metav1.Time #12518

merged 3 commits into from
Jul 25, 2025
+653 −327

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 23, 2025 •
edited
Loading

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
Follow-up to: #12506 (comment)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10852

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jul 23, 2025
@sbueringer sbueringer mentioned this pull request Jul 23, 2025
Merged
@k8s-ci-robot k8s-ci-robot requested review from elmiko and g-gaston July 23, 2025 14:22
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 23, 2025
@sbueringer sbueringer force-pushed the pr-remove-time-pointers branch 3 times, most recently from 9340952 to f9f4233 Compare July 23, 2025 15:03
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

1 similar comment
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@sbueringer sbueringer force-pushed the pr-remove-time-pointers branch from f9f4233 to 3df2eed Compare July 24, 2025 11:43
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025
@sbueringer sbueringer force-pushed the pr-remove-time-pointers branch from 3df2eed to ca1c4e5 Compare July 24, 2025 14:19
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 24, 2025
@sbueringer sbueringer added the area/api Issues or PRs related to the APIs label Jul 24, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 24, 2025
@sbueringer sbueringer changed the title [WIP] ⚠️ Change all *metav1.Time fields to metav1.Time ⚠️ Change all *metav1.Time fields to metav1.Time Jul 24, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2025
@sbueringer
Copy link
Member Author

/hold for migration doc updates
(will be done once #12521 is merged)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@sbueringer
Copy link
Member Author

/assign @fabriziopandini @JoelSpeed

@JoelSpeed
Copy link
Contributor

API changes LGTM

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

fabriziopandini
fabriziopandini reviewed Jul 24, 2025
View reviewed changes
@sbueringer sbueringer force-pushed the pr-remove-time-pointers branch from ca1c4e5 to 140b337 Compare July 25, 2025 08:52
@sbueringer
Copy link
Member Author

@fabriziopandini Should be all addressed. Also added docs

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 140b337 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1df43d4270594e383a3c837d520cdedcc2d87b39

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8bb9510 into kubernetes-sigs:main Jul 25, 2025
19 of 20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 25, 2025
@sbueringer sbueringer deleted the pr-remove-time-pointers branch July 25, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

@g-gaston g-gaston Awaiting requested review from g-gaston

Assignees

@fabriziopandini fabriziopandini

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @JoelSpeed @k8s-ci-robot @fabriziopandini