Skip to content

🌱 Remove nested provider from book #12487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

taladar
Copy link

@taladar taladar commented Jul 14, 2025

The nested provider repository is archived and the current version of clusterctl is not compatible with it anymore (v1beta1 vs. v1alpha4) so it should not be in the provider list in the book.

The nested provider repository is archived and the current version of clusterctl is not compatible with it anymore (v1beta1 vs. v1alpha4).
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @taladar!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from elmiko July 14, 2025 13:38
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sivchari July 14, 2025 13:38
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @taladar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@taladar
Copy link
Author

taladar commented Jul 14, 2025

Just so you know, I am not going to read multiple pages and sign a CLA for a PR that literally removes two lines from some documentation. Feel free to merge it anyway or close it if that is an insurmountable obstacle for your legal processes.

@sbueringer
Copy link
Member

cc @fabriziopandini

@fabriziopandini
Copy link
Member

FYI, last time we discussed this topic we decided to keep in the book also providers not mantained anymore, because they can still provide value to the community.

The book on main has been already updated accordingly https://main.cluster-api.sigs.k8s.io/reference/providers

@taladar
Copy link
Author

taladar commented Jul 15, 2025

In that link I see no indication that the providers are unmaintained, the downside is that I wasted time trying to get a provider working that is clearly not usable anymore because clusterctl literally refuses to use it.

@fabriziopandini
Copy link
Member

We tried to address this with:

Each provider is the responsibility of the respective maintainers and we highly recommend everyone interested in a specific provider to engage with the corresponding team to show support, share use cases, learn more about the other users of the same provider.

We also recommend to read provider’s documentation carefully, test it, and perform a proper due diligence before deciding to use a provider in production, like you will do for any other open source project.

Feel free to propose improvements to this statement if this is not clear enough.

@taladar
Copy link
Author

taladar commented Jul 15, 2025

Maybe providers that are just there for historical reasons and are known not to work with the current version could be moved to their own section at the end since they are really only relevant to people who might want to revive the project?

@fabriziopandini
Copy link
Member

Maybe providers that are just there for historical reasons and are known not to work with the current version could be moved to their own section at the end since they are really only relevant to people who might want to revive the project?

We discussed this option, but we did not want to/we don't have bandwidth to check all the providers periodically, and we considered not fair to take a stance only for a subset of providers (and without an agreed definition of what is un-mantained or mantained or what works and what not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants