-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Remove nested provider from book #12487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The nested provider repository is archived and the current version of clusterctl is not compatible with it anymore (v1beta1 vs. v1alpha4).
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @taladar! |
Hi @taladar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Just so you know, I am not going to read multiple pages and sign a CLA for a PR that literally removes two lines from some documentation. Feel free to merge it anyway or close it if that is an insurmountable obstacle for your legal processes. |
FYI, last time we discussed this topic we decided to keep in the book also providers not mantained anymore, because they can still provide value to the community. The book on main has been already updated accordingly https://main.cluster-api.sigs.k8s.io/reference/providers |
In that link I see no indication that the providers are unmaintained, the downside is that I wasted time trying to get a provider working that is clearly not usable anymore because clusterctl literally refuses to use it. |
We tried to address this with:
Feel free to propose improvements to this statement if this is not clear enough. |
Maybe providers that are just there for historical reasons and are known not to work with the current version could be moved to their own section at the end since they are really only relevant to people who might want to revive the project? |
We discussed this option, but we did not want to/we don't have bandwidth to check all the providers periodically, and we considered not fair to take a stance only for a subset of providers (and without an agreed definition of what is un-mantained or mantained or what works and what not). |
The nested provider repository is archived and the current version of clusterctl is not compatible with it anymore (v1beta1 vs. v1alpha4) so it should not be in the provider list in the book.