-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Update examples & code snippets in Cluster API book to v1beta2 for Cluster #12483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,7 +123,7 @@ Add the following content to the `namereference.yaml` transformer configuration: | |
```yaml | ||
- kind: Cluster | ||
group: cluster.x-k8s.io | ||
version: v1alpha3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wow, this was really old! Nice catch! |
||
version: v1beta2 | ||
fieldSpecs: | ||
- path: spec/clusterName | ||
kind: MachineDeployment | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,7 +92,7 @@ a target [management cluster] on the selected [infrastructure provider]. | |
```bash | ||
cat > kind-cluster-with-extramounts.yaml <<EOF | ||
kind: Cluster | ||
apiVersion: kind.x-k8s.io/v1alpha4 | ||
apiVersion: kind.x-k8s.io/v1beta2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. kind.x-k8s.io/v1alpha4 should not be bumped (it is still the current API version for kind configuration) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same below |
||
networking: | ||
ipFamily: dual | ||
nodes: | ||
|
@@ -127,7 +127,7 @@ a target [management cluster] on the selected [infrastructure provider]. | |
```bash | ||
cat <<EOF > kind-config.yaml | ||
kind: Cluster | ||
apiVersion: kind.x-k8s.io/v1alpha4 | ||
apiVersion: kind.x-k8s.io/v1beta2 | ||
networking: | ||
# the default CNI will not be installed | ||
disableDefaultCNI: true | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is docker cluster; are you planning a follow up PR taking care of all the other occurrences of DockerCluster/DockerClusterTemplate?