Skip to content

⚠️ Align CAPD conversion to conversion of other providers #12481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚠️ Align CAPD conversion to conversion of other providers #12481

wants to merge 1 commit into from
+202 −157

Conversation

sivchari
Copy link
Member

What this PR does / why we need it:

Part of #11947

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2025
@k8s-ci-robot k8s-ci-robot requested review from elmiko and JoelSpeed July 11, 2025 06:45
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2025
@sivchari
Copy link
Member Author

/assign @sbueringer

@sivchari
Copy link
Member Author

/assign @fabriziopandini

@sbueringer sbueringer added the area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider label Jul 11, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 11, 2025
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@sbueringer sbueringer mentioned this pull request Jul 11, 2025
Open
80 tasks
@sivchari
Copy link
Member Author

/override pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

@sivchari: sivchari unauthorized: /override is restricted to Repo administrators.

In response to this:

/override pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

sbueringer commented Jul 11, 2025 •
edited
Loading

/override pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main

In response to this:

/override pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

/hold

I'll do some refactoring around the initialization fields in #12482

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 14, 2025
@sivchari
align CAPD conversion to conversion of other providers
b2b6779 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari sivchari force-pushed the align-conversions branch from 04fce36 to b2b6779 Compare July 15, 2025 09:15
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from fabriziopandini. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2025
@sivchari
Copy link
Member Author

/retest

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2025
fabriziopandini
fabriziopandini reviewed Jul 15, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think that having consistently conversions about fields we shuffled around in ConvertTo/From is nice for the time being, thanks for this PR
Anyway, I can't wait to get rid of old API versions and conversions next year

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4827bcdfe8726b8c1493cd5b87e650cf9538ea60

@sivchari
Copy link
Member Author

/cc @sbueringer

@k8s-ci-robot k8s-ci-robot requested a review from sbueringer July 15, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sivchari @sbueringer @k8s-ci-robot @fabriziopandini