Skip to content

⚠️ Update ControlPlaneEndpoint InfraCluster contract, align CAPD to infra contracts #12465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

⚠️ Update ControlPlaneEndpoint InfraCluster contract, align CAPD to infra contracts #12465

merged 1 commit into from
Jul 14, 2025
+313 −106

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 8, 2025 •
edited
Loading

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
This PR:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #11947

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jul 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from elmiko and sivchari July 8, 2025 17:14
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2025
@sbueringer sbueringer changed the title [WIP] ⚠️ Update ControlPlaneEndpoint InfraCluster contract, align CAPD to infra [WIP] ⚠️ Update ControlPlaneEndpoint InfraCluster contract, align CAPD to infra contracts Jul 8, 2025
@sbueringer sbueringer added area/api Issues or PRs related to the APIs area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider labels Jul 8, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 8, 2025
@sbueringer sbueringer changed the title [WIP] ⚠️ Update ControlPlaneEndpoint InfraCluster contract, align CAPD to infra contracts ⚠️ Update ControlPlaneEndpoint InfraCluster contract, align CAPD to infra contracts Jul 8, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2025
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @JoelSpeed @sivchari @mboersma

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sivchari
Copy link
Member

sivchari commented Jul 8, 2025

/retest

sivchari
sivchari reviewed Jul 8, 2025
View reviewed changes
Copy link
Member

@sivchari sivchari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f830663149984cdb19f979f2d05d771bb97efebc

@sbueringer
Copy link
Member Author

/override pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main

In response to this:

/override pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoelSpeed
JoelSpeed reviewed Jul 9, 2025
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fabriziopandini
fabriziopandini reviewed Jul 14, 2025
View reviewed changes
docs/book/src/developer/providers/contracts/infra-cluster.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you kindly apply the same changes to the control plane contract (also control plane can surface a control plane endpoint)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Done

@sbueringer
Update ControlPlaneEndpoint InfraCluster contract, align CAPD to infra
1f85185 
contracts

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2025
fabriziopandini
fabriziopandini reviewed Jul 14, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7e15acb543a32aebcbd41aac78a727ff6b681ec6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 280776d into kubernetes-sigs:main Jul 14, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 14, 2025
@sbueringer sbueringer deleted the pr-capd-contract branch July 14, 2025 13:27
@sbueringer sbueringer mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@mboersma mboersma Awaiting requested review from mboersma

@sivchari sivchari Awaiting requested review from sivchari

Assignees

@mboersma mboersma

@fabriziopandini fabriziopandini

@JoelSpeed JoelSpeed

@sivchari sivchari

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Tracking issue for v1Beta2
6 participants
@sbueringer @sivchari @k8s-ci-robot @fabriziopandini @JoelSpeed @mboersma