-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Add back more v1beta1 util functions from v1.10.3 #12441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d251550
to
eb447f1
Compare
03bd179
to
2d58e55
Compare
/area util |
With v1beta2, some v1beta1 util functions have been saved in util/deprecated/v1beta1 for consumers that still support v1beta1 objects. This patch adds more v1beta1-focused utils packages to the deprecated/v1beta1 folder: * util * util/annnotations * util/collections * util/predicates
2d58e55
to
b77e212
Compare
@pierreprinetti: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@pierreprinetti what is the use case for restoring this utils? |
/close As per kubernetes-sigs/cluster-api-provider-openstack#2611 (comment)
|
@fabriziopandini: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
With v1beta2, some v1beta1 util functions have been saved in
util/deprecated/v1beta1
for consumers that still support v1beta1 objects. This patch adds more v1beta1-focused utils packages to the deprecated/v1beta1 folder:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #12440