-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🐛 test framework: fix e2e config provider's kustomize resource loading using a go getter url #12360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🐛 test framework: fix e2e config provider's kustomize resource loading using a go getter url #12360
Conversation
The committers listed above are authorized under a signed CLA. |
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @drinkingjasminegreentea! |
Hi @drinkingjasminegreentea. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it: This PR fixes a bug with loading kustomize resources from a go getter url. We only need to append the absolute path to provider.version.value if it's url scheme is file or empty. Removed the extra check for version type to check if it's kustomize or url, because both types can have either folder path or url values.
Which issue(s) this PR fixes:
fixes #12264
/area/e2e-testing