Skip to content

✨ Adding Addon Provider for cdk8s (CAAPC) to cluster-api #12332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/clusterctl/client/config/providers_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ const (
const (
HelmAddonProviderName = "helm"
FleetAddonProviderName = "rancher-fleet"
Cdk8sAddonProviderName = "patricklaabs-cdk8s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: We have trouble with providers being unmaintained. Could this be transfered to an org instead so ownership can be transitioned if needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chrischdi,
that would be definitely a plan for the future. I am currently researching, what needs to be done, to move it to the kubernetes-sigs org 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @chrischdi , any idea on how to move this forward?

)

// Runtime extensions providers.
Expand Down Expand Up @@ -441,6 +442,11 @@ func (p *providersClient) defaults() []Provider {
url: "https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/releases/latest/addon-components.yaml",
providerType: clusterctlv1.AddonProviderType,
},
&provider{
name: Cdk8sAddonProviderName,
url: "https://github.com/PatrickLaabs/cluster-api-addon-provider-cdk8s/releases/latest/addon-components.yaml",
providerType: clusterctlv1.AddonProviderType,
},

// Runtime extensions providers
&provider{
Expand Down
2 changes: 2 additions & 0 deletions cmd/clusterctl/client/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ func Test_clusterctlClient_GetProvidersConfig(t *testing.T) {
config.NutanixIPAMProviderName,
config.NutanixRuntimeExtensionsProviderName,
config.HelmAddonProviderName,
config.Cdk8sAddonProviderName,
config.FleetAddonProviderName,
},
wantErr: false,
Expand Down Expand Up @@ -177,6 +178,7 @@ func Test_clusterctlClient_GetProvidersConfig(t *testing.T) {
config.NutanixIPAMProviderName,
config.NutanixRuntimeExtensionsProviderName,
config.HelmAddonProviderName,
config.Cdk8sAddonProviderName,
config.FleetAddonProviderName,
},
wantErr: false,
Expand Down
5 changes: 5 additions & 0 deletions cmd/clusterctl/cmd/config_repositories_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ in-cluster IPAMProvider https://github.com/kubernetes
nutanix IPAMProvider https://github.com/nutanix-cloud-native/cluster-api-ipam-provider-nutanix/releases/latest/ ipam-components.yaml
nutanix RuntimeExtensionProvider https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/releases/latest/ runtime-extensions-components.yaml
helm AddonProvider https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/releases/latest/ addon-components.yaml
patricklaabs-cdk8s AddonProvider https://github.com/PatrickLaabs/cluster-api-addon-provider-cdk8s/releases/latest/ addon-components.yaml
rancher-fleet AddonProvider https://github.com/rancher-sandbox/cluster-api-addon-provider-fleet/releases/latest/ addon-components.yaml
`

Expand Down Expand Up @@ -387,6 +388,10 @@ var expectedOutputYaml = `- File: core_components.yaml
Name: helm
ProviderType: AddonProvider
URL: https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/releases/latest/
- File: addon-components.yaml
Name: patricklaabs-cdk8s
ProviderType: AddonProvider
URL: https://github.com/PatrickLaabs/cluster-api-addon-provider-cdk8s/releases/latest/
- File: addon-components.yaml
Name: rancher-fleet
ProviderType: AddonProvider
Expand Down
1 change: 1 addition & 0 deletions docs/book/src/reference/providers.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ source of inspiration and ideas for others.
## Addon
- [Fleet](https://github.com/rancher-sandbox/cluster-api-addon-provider-fleet/)
- [Helm](https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/)
- [Cdk8s](https://github.com/PatrickLaabs/cluster-api-addon-provider-cdk8s/)

## Runtime Extensions
- [Nutanix](https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/)
Expand Down
1 change: 1 addition & 0 deletions docs/release/role-handbooks/communications/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ We should inform at least the following providers via a new issue on their respe

* Addon provider fleet: https://github.com/rancher-sandbox/cluster-api-addon-provider-fleet/issues/new
* Addon provider helm: https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/issues/new
* Addon provider cdk8s: https://github.com/PatrickLaabs/cluster-api-addon-provider-cdk8s/issues/new
* AWS: https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/new
* Azure: https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/new
* Cloudstack: https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack/issues/new
Expand Down
Loading