Skip to content

⚠️ Remove clusterctl alpha topology plan #12283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

⚠️ Remove clusterctl alpha topology plan #12283

merged 1 commit into from
May 26, 2025
+85 −3,635

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented May 23, 2025 •
edited
Loading

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10138
Part of #10852

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 23, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 23, 2025
@sbueringer sbueringer mentioned this pull request May 23, 2025
Open
76 tasks
@sbueringer sbueringer added the area/clusterctl Issues or PRs related to clusterctl label May 23, 2025
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-area PR is missing an area label labels May 23, 2025
@sbueringer sbueringer force-pushed the pr-remove-alpha-dryrun branch 2 times, most recently from 8353785 to 26b44dc Compare May 23, 2025 14:10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2025
@sbueringer sbueringer changed the title [WIP] ⚠️ Remove clusterctl alpha topology plan ⚠️ Remove clusterctl alpha topology plan May 23, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2025
@sbueringer sbueringer force-pushed the pr-remove-alpha-dryrun branch from 26b44dc to 13d4252 Compare May 23, 2025 14:18
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-remove-alpha-dryrun branch from 13d4252 to a4d4ff3 Compare May 23, 2025 16:59
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

fabriziopandini
fabriziopandini reviewed May 26, 2025
View reviewed changes
@sbueringer sbueringer force-pushed the pr-remove-alpha-dryrun branch from a4d4ff3 to fd68faf Compare May 26, 2025 11:04
fabriziopandini
fabriziopandini reviewed May 26, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a long awaited cleanup!
If someone cares about testing patches, using runtime extensions and a proper language is the way to go

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5d418fa58992860a97d4a089eaef562fe87652f

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@sbueringer
Remove clusterctl alpha topology plan + Cleanup Cluster topology
fefd5ac 
controller

Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-remove-alpha-dryrun branch from fd68faf to fefd5ac Compare May 26, 2025 13:20
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2025
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 10c88ec9952512856036dd48954361fa69a98547

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d2d0b70 into kubernetes-sigs:main May 26, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 26, 2025
@sbueringer sbueringer deleted the pr-remove-alpha-dryrun branch May 26, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@richardcase richardcase Awaiting requested review from richardcase

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Deprecate & remove "clusterctl alpha topology plan"
3 participants
@sbueringer @k8s-ci-robot @fabriziopandini