Skip to content

⚠️ Remove KubeadmConfig UseExperimentalRetryJoin #12234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6942
Part of #10852

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2025
@k8s-ci-robot k8s-ci-robot requested review from chrischdi and elmiko May 16, 2025 14:40
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 16, 2025
@sbueringer sbueringer mentioned this pull request May 16, 2025
71 tasks
@sbueringer sbueringer changed the title ⚠️ Remove KubeadmConfig UseExperimentalRetryJoin [WIP] ⚠️ Remove KubeadmConfig UseExperimentalRetryJoin May 16, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2025
@sbueringer sbueringer added area/provider/control-plane-kubeadm Issues or PRs related to KCP area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 16, 2025
@k8s-ci-robot k8s-ci-robot removed do-not-merge/needs-area PR is missing an area label labels May 16, 2025
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-remove-experimental-retry-join branch from a81eaca to 969b81a Compare May 16, 2025 14:47
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer changed the title [WIP] ⚠️ Remove KubeadmConfig UseExperimentalRetryJoin ⚠️ Remove KubeadmConfig UseExperimentalRetryJoin May 16, 2025
@sbueringer
Copy link
Member Author

sbueringer commented May 16, 2025

Finally 🎉 🎉 🎉 🕺 💃 👯‍♂️ 👯‍♀️

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took ages, but great to see this finally happen!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ad1c5387c2d35b69c82f40ba24ce815bea64bc3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit f8f2ca2 into kubernetes-sigs:main May 19, 2025
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 19, 2025
@sbueringer sbueringer deleted the pr-remove-experimental-retry-join branch May 19, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove experimentalRetryJoin
3 participants