🌱 Enable usetesting linter

[sivchari]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12179

[JoelSpeed]

Seems reasonable, just switched context.TODO/Background for t.Context across many files

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 9f4feb08815933df803ab6e77da92cf5d83d0aeb

[fabriziopandini]

/lgtm

[fabriziopandini]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

Do we know how this will work in combination with ctrl.SetupSignalHandler() that we use in many places?

Which context will be cancelled first? Will the shutdown still be somewhat clean?

[sbueringer]

+ should we use either t.Context() or ctrl.SetupSignalHandler() everywhere? Or continue to have that mix that we currently have? Or do we know in which cases we would want to use which one

[sivchari]

t.Context() is canceled before t.Cleanup, then ctrl.SetupSignalHandler doesn't cancel until the signal is received. So it might be good to use properly. For example, how about is it ?

• ctrl.SetupSignalHandler should be only used when it's suite test.
• t.Context() should be only used other than suite test.

[sbueringer]

Sorry will get back to this eventually. Just a lot of other things going on

[sbueringer]

(low priority at the moment) I wonder if we could/should get rid of ctrl.SetupSignalHandler() entirely.

I wonder what the difference is between using t.Context and ctrl.SetupSignalHandler in suite_test.go.

Is one more graceful then the other? Maybe let's test this manually?

Context:
ctrl.SetupSignalHandler will cancel the context on the first signal and os.Exit(1) on the second. I don't know how tests with t.Context behave when the test binary receives signals

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[sivchari]

/area ci
/hold We discuss later

[k8s-ci-robot]

@sivchari: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-test-main	6056d61	link	true	/test pull-cluster-api-test-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.