Skip to content

⚠️ Remove ClusterVariable.DefinitionFrom field #12202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

⚠️ Remove ClusterVariable.DefinitionFrom field #12202

merged 1 commit into from
May 15, 2025

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented May 13, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10666
Part of #10852

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-remove-definition-from branch 2 times, most recently from 373197a to c5df2d3 Compare May 13, 2025 16:56
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer mentioned this pull request May 13, 2025
Open
71 tasks
@sbueringer
Copy link
Member Author

@killianmuldoon Finally!

@sbueringer sbueringer added the area/clusterclass Issues or PRs related to clusterclass label May 13, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label May 13, 2025
@sbueringer sbueringer force-pushed the pr-remove-definition-from branch from c5df2d3 to 219b996 Compare May 13, 2025 17:13
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 13, 2025 •
edited
Loading

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 219b996 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

Pending test completion

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 41b85b1a184951704fd7134b77990af4a73bd494

@sbueringer sbueringer changed the title ✨ Remove ClusterVariable.DefinitionFrom field ⚠️ Remove ClusterVariable.DefinitionFrom field May 15, 2025
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @chrischdi @sivchari

fabriziopandini
fabriziopandini reviewed May 15, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, it took a long time and work to get here!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2025
@sivchari
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 095a054 into kubernetes-sigs:main May 15, 2025
28 of 29 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 15, 2025
@sbueringer sbueringer deleted the pr-remove-definition-from branch May 15, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

@JoelSpeed JoelSpeed

@sivchari sivchari

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Deprecate definitionFrom in cluster variables
6 participants
@sbueringer @k8s-ci-robot @JoelSpeed @sivchari @fabriziopandini @chrischdi