Skip to content

🌱 Add Namingstrategy to InfraCluster #11898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 5, 2025
Merged

🌱 Add Namingstrategy to InfraCluster #11898

merged 5 commits into from
Mar 5, 2025

Conversation

arshadd-b
Copy link
Contributor

@arshadd-b arshadd-b commented Feb 25, 2025 •
edited by chrischdi
Loading

What this PR does / why we need it:
This PR adds NamingStrategy for InfrastructureCluster
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #11671

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2025
@arshadd-b arshadd-b force-pushed the infra-namingstrategy branch from d639dda to 130b140 Compare February 25, 2025 03:54
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2025
@sbueringer sbueringer added the area/clusterclass Issues or PRs related to clusterclass label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Feb 25, 2025
chrischdi
chrischdi reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prod code looks good to me 🎉

Small findings on validation test code

@sbueringer
Copy link
Member

@chrischdi I'll take a look once you've added lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2025
@arshadd-b arshadd-b force-pushed the infra-namingstrategy branch from f681d0e to 8a33973 Compare March 3, 2025 14:14
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2025
@arshadd-b arshadd-b requested a review from chrischdi March 4, 2025 04:37
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 106cee92ced554b2f097959c523e209618cdf26d

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 4, 2025
sbueringer
sbueringer reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there :)

@sbueringer
Copy link
Member

Just a heads up. Code freeze for 1.10 is on 18th March. So we maybe have 1,5 weeks left if this should make it into v1.10.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@arshadd-b arshadd-b force-pushed the infra-namingstrategy branch from daae453 to d270f2b Compare March 5, 2025 14:15
@sbueringer
Copy link
Member

Thank you very much, nice work!

/approve

/assign @chrischdi

for a final review

@arshadd-b arshadd-b requested a review from sbueringer March 5, 2025 15:55
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@chrischdi
Copy link
Member

two more nits, otherwise good to go form my side :-)

@chrischdi
Copy link
Member

/retest

(networking / go mod download flake)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d29e97b9977c2dbee13074b39f2b76e0cff5f29

@chrischdi
Copy link
Member

Thanks a lot @arshadd-b for the work and also for following up so fast! 🎉

@k8s-ci-robot k8s-ci-robot merged commit 4fd9458 into kubernetes-sigs:main Mar 5, 2025
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Mar 5, 2025
cprivitere pushed a commit to cprivitere/cluster-api that referenced this pull request Mar 18, 2025
@arshadd-b @cprivitere
🌱 Add Namingstrategy to InfraCluster (kubernetes-sigs#11898)
6af7835 
* Add Namingstrategy to infracluster

* address review comments

* address review comment

* address review comments

* address review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

Add namingStrategy for InfrastructureCluster
4 participants
@arshadd-b @k8s-ci-robot @sbueringer @chrischdi