-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨ Implement Priority
and Serial
settings for discovered handlers
#11818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Implement Priority
and Serial
settings for discovered handlers
#11818
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Priority
and Serial
settings for discovered handlersPriority
and Serial
settings for discovered handlers
a77347a
to
42b3f4e
Compare
Priority
and Serial
settings for discovered handlersPriority
and Serial
settings for discovered handlers
9fb72a6
to
7d2e096
Compare
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
7d2e096
to
f034ec7
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What this PR does / why we need it:
In-place upgrades defines
machine-updates
process as looping until completion for each registered updater.In order to leverage runtime extensions in processing these updaters, handler execution needs to be able to block (retry until completion) on individual updater, in case it responds with pending status before requesting other unfinished hooks. This PR introduces
serial
setting for the handler discovery.Additionally, current handlers list is not guarantied to be ordered, so it may cause a situation when:
On the second iteration:
To address this, a
priority
field is added, which allows updaters to declare execution order.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes rancher/highlander#118
/area runtime-sdk