[release-0.9] Bump golangci-lint

[mandre]

Trying to debug CI failures in release-0.9 branch.

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	5541d6e
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/6875231167d9850008cddf1a
😎 Deploy Preview	https://deploy-preview-2619--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign emilienm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@mandre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-openstack-e2e-test	5541d6e	link	true	/test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mandre]

OK, this has fixed the failure we saw with pull-cluster-api-provider-openstack-test however I'm not entirely satisfied, we should used a pinned version of go so that we don't run into issues in the future.

And there's a chance we have the same problem with the other stable branches.

[mandre]

I'm not getting why GOTOOLCHAIN=go1.22.8 doesn't seem to be picked up in CI.

Looking at this job failure, from #2612, we should see lines such as go: downloading go1.22.8 (linux/amd64) but we're not.

Trying to replicate locally, using the same image that is being used in CI, I'm not having the problem:

❯ podman run --rm --entrypoint /bin/bash gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250613-876fb90a97-master -c "git clone https://github.com/kubernetes-sigs/cluster-api-provider-openstack.git -b release-0.9; cd cluster-api-provider-openstack; make lint"
Cloning into 'cluster-api-provider-openstack'...
make -C hack/tools bin/golangci-lint
make[1]: Entering directory '/workspace/cluster-api-provider-openstack/hack/tools'
go: downloading go1.22.8 (linux/amd64)
mkdir -p bin
./ensure-golangci-lint.sh -b bin v1.54.2
golangci/golangci-lint info checking GitHub for tag 'v1.54.2'
golangci/golangci-lint info found version: 1.54.2 for v1.54.2/linux/amd64
golangci/golangci-lint info installed bin/golangci-lint
make[1]: Leaving directory '/workspace/cluster-api-provider-openstack/hack/tools'
hack/tools/bin/golangci-lint run -v --fast=false
level=info msg="[config_reader] Config search paths: [./ /workspace/cluster-api-provider-openstack /workspace / /root]"
level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="[lintersdb] Active 47 linters: [asasalint asciicheck bidichk bodyclose cyclop dogsled dupword durationcheck errcheck exportloopref forbidigo gci goconst gocritic gocyclo godot gofmt gofumpt goheader goimports gomodguard goprintffuncname gosec gosimple govet importas ineffassign makezero misspell nakedret nestif nilerr noctx nolintlint prealloc predeclared revive rowserrcheck sqlclosecheck staticcheck stylecheck thelper unconvert unparam unused wastedassign whitespace]"
level=info msg="[loader] Using build tags: [e2e]"
level=info msg="[loader] Go packages loading at mode 575 (compiled_files|files|name|types_sizes|deps|exports_file|imports) took 1m15.404779941s"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 24.957759ms"
level=info msg="[linters_context/goanalysis] analyzers took 10m17.610491812s with top 10 stages: buildir: 5m38.707611551s, gocritic: 1m51.410613508s, goimports: 21.745358365s, nilness: 17.55712907s, bidichk: 14.008850206s, the_only_name: 13.881633366s, fact_purity: 12.452365037s, fact_deprecated: 12.227488806s, printf: 11.328795613s, ctrlflow: 11.286286877s"
level=info msg="[runner] Issues before processing: 673, after processing: 0"
level=info msg="[runner] Processors filtering stat (out/in): filename_unadjuster: 673/673, path_prettifier: 673/673, skip_dirs: 444/444, exclude: 444/444, exclude-rules: 12/444, skip_files: 444/673, autogenerated_exclude: 444/444, cgo: 673/673, identifier_marker: 444/444, nolint: 0/12"
level=info msg="[runner] processing took 32.275576ms with stages: exclude-rules: 16.772909ms, identifier_marker: 8.539655ms, nolint: 2.725422ms, autogenerated_exclude: 2.395487ms, path_prettifier: 1.485711ms, skip_dirs: 188.504µs, skip_files: 106.865µs, cgo: 34.714µs, filename_unadjuster: 23.013µs, max_same_issues: 849ns, exclude: 456ns, fixer: 396ns, uniq_by_line: 355ns, diff: 247ns, source_code: 231ns, severity-rules: 192ns, sort_results: 170ns, max_from_linter: 140ns, max_per_file_from_linter: 92ns, path_shortener: 90ns, path_prefixer: 78ns"
level=info msg="[runner] linters took 1m1.249761493s with stages: goanalysis_metalinter: 1m1.217419716s"
level=info msg="File cache stats: 177 entries of total size 1.4MiB"
level=info msg="Memory: 1281 samples, avg is 1016.5MB, max is 4411.3MB"
level=info msg="Execution took 2m16.695956715s"