Remove deprecated admission interfaces #2289
Merged
+238
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/ibmcloud
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Karthik-K-N
force-pushed
the
remove-deprecated-methods
branch
from
01bf7cf to
494c9d6
Compare
|
/hold Need to implement for rest of the types |
k8s-ci-robot
added
the
do-not-merge/hold
Karthik-K-N
force-pushed
the
remove-deprecated-methods
branch
from
494c9d6 to
f162156
Compare
k8s-ci-robot
added
size/L
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Karthik-K-N
force-pushed
the
remove-deprecated-methods
branch
from
f162156 to
fc8168b
Compare
Karthik-K-N
force-pushed
the
remove-deprecated-methods
branch
from
fc8168b to
347faef
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amulyam24, Karthik-K-N, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PR removes the deprecated webhook interfaces and adds CustomValidator.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2288
Special notes for your reviewer:
/area provider/ibmcloud
Release note: