Add VMSS-based scalability test templates #5784
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XXL
scripts/ci-entrypoint.sh
Outdated
| @@ -138,6 +138,8 @@ select_cluster_template() { | |||
| export CLUSTER_TEMPLATE="${CLUSTER_TEMPLATE/custom-builds/custom-builds-machine-pool}" | |||
| fi | |||
| fi | |||
|
|
|||
| export CLUSTER_TEMPLATE="test/dev/cluster-template-custom-builds-machine-pool-load-dra.yaml" | |||
There was a problem hiding this comment.
I intend to drop this and configure it in test-infra once we're confident here that it will work.
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds
nojnhuh
force-pushed
the
load-vmss-template
branch
from
377091c to
45c51e7
Compare
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5784 +/- ##
=======================================
Coverage ? 52.94%
=======================================
Files ? 279
Lines ? 29666
Branches ? 0
=======================================
Hits ? 15706
Misses ? 13147
Partials ? 813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
/test ? |
|
@nojnhuh: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-azure-load-test-1k-dra-with-workload-custom-builds |
1 similar comment
|
/test pull-cluster-api-provider-azure-load-test-1k-dra-with-workload-custom-builds |
|
/test pull-cluster-api-provider-azure-load-test-1k-dra-with-workload-custom-builds |
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
2 similar comments
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
scripts/ci-entrypoint.sh
Outdated
| @@ -88,6 +88,7 @@ setup() { | |||
| if [[ -z "${CLUSTER_TEMPLATE:-}" ]]; then | |||
| select_cluster_template | |||
| fi | |||
| export CLUSTER_TEMPLATE="test/dev/cluster-template-custom-builds-machine-pool-load-dra.yaml" | |||
There was a problem hiding this comment.
/hold
Reminder to remove this as soon as the test-infra job sets this.
There was a problem hiding this comment.
We can update periodic jobs after this merges, I reckon.
k8s-ci-robot
added
the
do-not-merge/hold
|
I need to clean up the commit history here, but this should be representative of the changes I intend to merge here aside from the /retitle Add VMSS-based scalability test templates |
k8s-ci-robot
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
1 similar comment
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
Watching in the portal, it seemed some VMSS instances were failing to provision due to an Azure internal error, although the k8s Node objects were all already Ready. I noticed after the test had already timed out and was collecting logs, the VMSS did eventually recover to 100/100 successful instances. This case I think is anomalous enough that it's probably not worth budgeting for by increasing timeouts. /test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
/retest |
|
@willie-yao That test is flaky on main too. I think I need to take a look at the config, but this PR shouldn't be affecting that. |
nojnhuh
force-pushed
the
load-vmss-template
branch
from
f0b6b10 to
f23d80f
Compare
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
This is all cleaned up now and ready for review. Keeping the |
nojnhuh
force-pushed
the
load-vmss-template
branch
from
f23d80f to
f0476f1
Compare
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
DRA load test passed. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
@nojnhuh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b18a4bcb78ac8b78b4281c803507b8a8f4f79d58
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds load templates with VMSS-based worker nodes, for clusters both with and without DRA.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: