-
Notifications
You must be signed in to change notification settings - Fork 449
Fix format strings #5743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix format strings #5743
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5743 +/- ##
=======================================
Coverage 52.84% 52.84%
=======================================
Files 278 278
Lines 29610 29610
=======================================
Hits 15647 15647
Misses 13146 13146
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 3958c74f8e586f0ca6d7f73869b777f81d4eb7ec
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Use static format string since
err.Error()
shouldn't be used as one as it could contain%
.TODOs:
Release note: