[WIP] Default to windows-2025 community gallery images

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Changes the "default Windows image" logic to use windows-2025 containers, instead of the deprecated windows-2019 versions.

Which issue(s) this PR fixes:

Fixes #5357

Special notes for your reviewer:

This is unlikely to "just work," so I'm using this PR to gather debug information.

TODOs:

• squashed commits
• includes documentation
• adds unit tests
• cherry-pick candidate

Release note:

Default to windows-2025 community gallery images

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nawazkh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

/test pull-cluster-api-provider-azure-e2e

[mboersma]

There's also the question of how to keep the upgrade tests from failing when an earlier codebase provisions windows-2019 nodes and the upgraded CAPZ finds the same version, but from windows-2025. (See #5266 for more context.)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.84%. Comparing base (5b0130c) to head (c889758).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5635   +/-   ##
=======================================
  Coverage   52.84%   52.84%           
=======================================
  Files         278      278           
  Lines       29610    29610           
=======================================
  Hits        15647    15647           
  Misses      13146    13146           
  Partials      817      817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[willie-yao]

/retest

[mboersma]

/test pull-cluster-api-provider-azure-e2e

I'm curious if this behaves differently now that I've rebuilt the most recent Windows images with kubernetes-sigs/image-builder#1798 and windows_service rather than nssm.

[k8s-ci-robot]

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-conformance-custom-builds	a105ddf	link	false	/test pull-cluster-api-provider-azure-conformance-custom-builds
pull-cluster-api-provider-azure-e2e-aks	a105ddf	link	true	/test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-e2e	c889758	link	true	/test pull-cluster-api-provider-azure-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.