Skip to content

Reconciled merged kustomize for prow-ci-version and prow-machine-pool… #5599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reconciled merged kustomize for prow-ci-version and prow-machine-pool… #5599

wants to merge 1 commit into from

Conversation

alimaazamat
Copy link
Contributor

@alimaazamat alimaazamat commented Apr 30, 2025 •
edited
Loading

…-ci-version

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5441

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 30, 2025
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @alimaazamat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.26%. Comparing base (1a9b38b) to head (e2ef2dd).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5599      +/-   ##
==========================================
- Coverage   53.26%   53.26%   -0.01%     
==========================================
  Files         272      272              
  Lines       29529    29529              
==========================================
- Hits        15730    15728       -2     
- Misses      12984    12986       +2     
  Partials      815      815

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2025
@alimaazamat
Copy link
Contributor Author

/retest

@alimaazamat alimaazamat force-pushed the combine-templates branch 2 times, most recently from e17c2e0 to d7785f4 Compare May 2, 2025 17:21
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 2, 2025
@alimaazamat alimaazamat force-pushed the combine-templates branch from d7785f4 to 47ae3f8 Compare May 2, 2025 22:06
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2025
@alimaazamat alimaazamat force-pushed the combine-templates branch from 47ae3f8 to 43ccf97 Compare May 2, 2025 22:12
@alimaazamat
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 5, 2025
@alimaazamat
Copy link
Contributor Author

/retest

2 similar comments
@alimaazamat
Copy link
Contributor Author

/retest

@alimaazamat
Copy link
Contributor Author

/retest

@alimaazamat
Copy link
Contributor Author

/retest

2 similar comments
@alimaazamat
Copy link
Contributor Author

/retest

@alimaazamat
Copy link
Contributor Author

/retest

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot May 20, 2025
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot May 20, 2025
@kubernetes-sigs kubernetes-sigs deleted a comment from alimaazamat May 20, 2025
@alimaazamat alimaazamat changed the title WIP: reconciled merged kustomize for prow-ci-version and prow-machine-pool… Reconciled merged kustomize for prow-ci-version and prow-machine-pool… May 21, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2025
willie-yao
willie-yao approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 05853f1f71059ac51cd95ca63ac0cd2ccc099ce7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025
@alimaazamat alimaazamat force-pushed the combine-templates branch 2 times, most recently from 385b86d to ccd652c Compare May 21, 2025 21:54
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from willie-yao May 21, 2025 21:54
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@willie-yao
Copy link
Contributor

/retest

willie-yao
willie-yao reviewed May 21, 2025
View reviewed changes
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 22, 2025 •
edited
Loading

@alimaazamat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-verify e2ef2dd link true /test pull-cluster-api-provider-azure-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willie-yao willie-yao willie-yao approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
CAPZ Planning
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine ci-conformance machine deployment + machinepool templates
4 participants
@alimaazamat @k8s-ci-robot @mboersma @willie-yao