Skip to content

Update all the kubernetes versions to 1.32 #5528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Mar 28, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
1.29 is EOL, this updates all reference to keep things fresh.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Update default Kubernetes version to 1.32

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.26%. Comparing base (1a9b38b) to head (cfc3978).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5528   +/-   ##
=======================================
  Coverage   53.26%   53.26%           
=======================================
  Files         272      272           
  Lines       29529    29529           
=======================================
  Hits        15730    15730           
  Misses      12984    12984           
  Partials      815      815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsturtevant
Copy link
Contributor Author

@mboersma are we still building flatcar images?

 <*exported.ResponseError | 0xc000c524e0>: 
      GET https://management.azure.com/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/providers/Microsoft.Compute/locations/uksouth/communityGalleries/flatcar4capi-742ef0cb-dcaa-4ecb-9cb0-bfd2e43dccc0/images/flatcar-stable-amd64-capi-stable-1.32/versions
      --------------------------------------------------------------------------------
      RESPONSE 404: 404 Not Found
      ERROR CODE: NotFound

@mboersma
Copy link
Contributor

are we still building flatcar images?

The CAPZ team never did build them, but the Flatcar team was building them in a community gallery. But AFAICT they stopped publishing a while back, once they got their preferred sysext approach working.

@jsturtevant
Copy link
Contributor Author

are we still building flatcar images?

The CAPZ team never did build them, but the Flatcar team was building them in a community gallery. But AFAICT they stopped publishing a while back, once they got their preferred sysext approach working.

I can revert the changes to these versions but should these tests be dropped if they aren't maintained?

@jsturtevant
Copy link
Contributor Author

/retest

@jsturtevant jsturtevant changed the title Update all the kubernetes versions Update all the kubernetes versions to 1.32 Apr 1, 2025
@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-apiversion-upgrade

@jsturtevant
Copy link
Contributor Author

/retest

@jsturtevant
Copy link
Contributor Author

I am seeing the same panic in the cloudprovider image: #5523 (comment)

It seem that test is buggy

/retest

@jsturtevant
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor

mboersma commented Apr 2, 2025

should these tests be dropped if they aren't maintained?

Yes, probably. We could ask the Flatcar team for their opinions--I know they prefer sysext to baking full node images.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
@jsturtevant
Copy link
Contributor Author

failure looks like a flake on the azure cni test
/test pull-cluster-api-provider-azure-e2e

@jsturtevant
Copy link
Contributor Author

/retest

1 similar comment
@nawazkh
Copy link
Member

nawazkh commented May 5, 2025

/retest

@nawazkh
Copy link
Member

nawazkh commented May 7, 2025

Is the recent run of the test a flake ? Let's retest
/test pull-cluster-api-provider-azure-e2e-workload-upgrade

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d53edd01c193fdc857bfc894fcae4bdefcb0f83

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2025
@nawazkh
Copy link
Member

nawazkh commented May 13, 2025

/test pull-cluster-api-provider-azure-e2e-workload-upgrade

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot requested a review from willie-yao May 13, 2025 13:44
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from willie-yao. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2025
@willie-yao
Copy link
Contributor

/retest

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2025
@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-apiversion-upgrade

@jsturtevant
Copy link
Contributor Author

/retest

1 similar comment
@willie-yao
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-conformance 8c10b38 link false /test pull-cluster-api-provider-azure-conformance
pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts 8c10b38 link false /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-custom-builds 8c10b38 link false /test pull-cluster-api-provider-azure-conformance-custom-builds
pull-cluster-api-provider-azure-apiversion-upgrade cfc3978 link true /test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-e2e cfc3978 link true /test pull-cluster-api-provider-azure-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants