fix: lease based controller when using mTLS #728
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ipochi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
currently when the lease based server count is enabled along with mTLS between apiserver and konnectivity server, it breaks. this fixes this by setting up the k8s clientset correctly. Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
ipochi
force-pushed
the
imran/test-based-on-#670
branch
from
1ecc404 to
cd7c550
Compare
|
@ipochi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ipochi
added a commit
to kinvolk/apiserver-network-proxy
that referenced
this pull request
Apr 16, 2025
Currently the setting up of k8s client is broken if service account
authentication is not used between server and agent.
This condition `if o.AgentNamespace != "" {` acts as a gatekeeper for
setting the k8s client which worked fine previously as server never
needed to talk to apiserver apart from authenticating agents using
service account token.
However when lease controller logic was added, it meant that setting up
k8s client was required if lease controller was enabled but
authentication was done using mTLS instead of service account
authentication.
This fixes that.
Closing kubernetes-sigs#728 in favour of this.
Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
ipochi
added a commit
to kinvolk/apiserver-network-proxy
that referenced
this pull request
Apr 18, 2025
Currently the setting up of k8s client is broken if service account
authentication is not used between server and agent.
This condition `if o.AgentNamespace != "" {` acts as a gatekeeper for
setting the k8s client which worked fine previously as server never
needed to talk to apiserver apart from authenticating agents using
service account token.
However when lease controller logic was added, it meant that setting up
k8s client was required if lease controller was enabled but
authentication was done using mTLS instead of service account
authentication.
This fixes that.
Closing kubernetes-sigs#728 in favour of this.
Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
ipochi
added a commit
that referenced
this pull request
May 7, 2025
Currently the setting up of k8s client is broken if service account
authentication is not used between server and agent.
This condition `if o.AgentNamespace != "" {` acts as a gatekeeper for
setting the k8s client which worked fine previously as server never
needed to talk to apiserver apart from authenticating agents using
service account token.
However when lease controller logic was added, it meant that setting up
k8s client was required if lease controller was enabled but
authentication was done using mTLS instead of service account
authentication.
This fixes that.
Closing #728 in favour of this.
Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
ipochi
added a commit
to kinvolk/apiserver-network-proxy
that referenced
this pull request
May 7, 2025
Currently the setting up of k8s client is broken if service account
authentication is not used between server and agent.
This condition `if o.AgentNamespace != "" {` acts as a gatekeeper for
setting the k8s client which worked fine previously as server never
needed to talk to apiserver apart from authenticating agents using
service account token.
However when lease controller logic was added, it meant that setting up
k8s client was required if lease controller was enabled but
authentication was done using mTLS instead of service account
authentication.
This fixes that.
Closing kubernetes-sigs#728 in favour of this.
Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently when the lease based server count is enabled along with mTLS between apiserver and konnectivity server, it breaks.
this fixes this by setting up the k8s clientset correctly.