Skip to content

Conversation

akshaychitneni
Copy link
Contributor

What this PR does / why we need it:
Adds build pipeline and fixes vulnerabilities in data_cache
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes # #2889

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Oct 13, 2025

Pull Request Test Coverage Report for Build 18604211719

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.147%

Totals Coverage Status
Change from base Build 18598312609: 0.0%
Covered Lines: 1263
Relevant Lines: 2422

💛 - Coveralls

@akshaychitneni akshaychitneni changed the title KEP-2655(cache): Add build pipeline and address vulnerabilities for data_cache feat(cache): KEP-2655 - Add build pipeline and address vulnerabilities for data_cache Oct 13, 2025
with:
toolchain: stable

- name: Cache Rust dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would speed up builds by caching rust dependencies using cargo.lock for runs in the repo

@akshaychitneni akshaychitneni force-pushed the cache_pipeline branch 5 times, most recently from 8aa0e88 to 46d3201 Compare October 17, 2025 19:09
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
@akshaychitneni Feel free to un-hold if PR is ready
/hold

Signed-off-by: Akshay Chitneni <achitneni@apple.com>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Oct 18, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 5b0e1ca into kubeflow:master Oct 18, 2025
28 checks passed
@google-oss-prow google-oss-prow bot added this to the v2.1 milestone Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants