-
Notifications
You must be signed in to change notification settings - Fork 834
feat(cache): KEP-2655 - Add build pipeline and address vulnerabilities for data_cache #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cache): KEP-2655 - Add build pipeline and address vulnerabilities for data_cache #2890
Conversation
Pull Request Test Coverage Report for Build 18604211719Details
💛 - Coveralls |
57d1b55
to
ef32655
Compare
with: | ||
toolchain: stable | ||
|
||
- name: Cache Rust dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would speed up builds by caching rust dependencies using cargo.lock for runs in the repo
8aa0e88
to
46d3201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@akshaychitneni Feel free to un-hold if PR is ready
/hold
Signed-off-by: Akshay Chitneni <achitneni@apple.com>
46d3201
to
3ec202f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
Adds build pipeline and fixes vulnerabilities in data_cache
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes # #2889
Checklist: