Skip to content

Conversation

kaisoz
Copy link
Contributor

@kaisoz kaisoz commented Oct 6, 2025

What this PR does / why we need it:
Currently, it's forbidden to create a TrainJob that include PodSpecOverrides with duplicated targetJobs. This breaks the Kueue integration when there are user-provided podSpecOverrides because it injects its configuration using this API

This PR fixes this by removing such limitation

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2871

Checklist:

  • Docs included if any changes are user facing

@kaisoz
Copy link
Contributor Author

kaisoz commented Oct 6, 2025

/assign @astefanutti

PTAL! Thanks! 😊

cc @andreyvelich @tenzen-y

@kaisoz kaisoz changed the title Allow TrainJobs to include podSpecOverrides with duplicated targetJobs fix: Allow TrainJobs to include podSpecOverrides with duplicated targetJobs Oct 6, 2025
@kaisoz kaisoz force-pushed the 2871-allow-podspecoverride-dupl-jobs branch from 097f58e to 10da76b Compare October 6, 2025 21:36
@coveralls
Copy link

coveralls commented Oct 6, 2025

Pull Request Test Coverage Report for Build 18312702644

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 54.442%

Totals Coverage Status
Change from base Build 18271389532: -0.05%
Covered Lines: 1201
Relevant Lines: 2206

💛 - Coveralls

@kaisoz kaisoz force-pushed the 2871-allow-podspecoverride-dupl-jobs branch from 10da76b to 4d2a9cf Compare October 6, 2025 21:38
@mimowo
Copy link

mimowo commented Oct 7, 2025

nit about title, I wouldn't call it "duplicated targetJobs", it sounds like allowing a bug.

"fix: Allow multiple podSpec overrides to target the same TargetJob"

wdyt?

@kaisoz kaisoz changed the title fix: Allow TrainJobs to include podSpecOverrides with duplicated targetJobs fix: Allow multiple podSpec overrides to target the same TargetJob Oct 7, 2025
@kaisoz kaisoz force-pushed the 2871-allow-podspecoverride-dupl-jobs branch from 4d2a9cf to f9487ea Compare October 7, 2025 11:12
@kaisoz kaisoz force-pushed the 2871-allow-podspecoverride-dupl-jobs branch from f9487ea to b7505ba Compare October 7, 2025 11:24
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Oct 7, 2025
Signed-off-by: Tomas Tormo <tomas.tormo@gmail.com>
@kaisoz kaisoz force-pushed the 2871-allow-podspecoverride-dupl-jobs branch from b7505ba to 1843634 Compare October 7, 2025 12:30
@google-oss-prow google-oss-prow bot added size/M and removed size/L labels Oct 7, 2025
@astefanutti
Copy link
Contributor

/lgtm

Thanks @kaisoz!

@google-oss-prow google-oss-prow bot added the lgtm label Oct 7, 2025
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 25022bd into kubeflow:master Oct 7, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The admission webhook rejects TrainJobs with more than one PodSpecOverride targeting the same job

6 participants