-
Notifications
You must be signed in to change notification settings - Fork 834
chore(test): Support e2e cluster setup with Podman #2861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 18186567965Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
44121d4
to
d71c92c
Compare
Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
Hi @andreyvelich Can you please add the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astefanutti Did you add support for Podman to allow users run this E2Es locally, right?
IIUC, we still use Docker for our CI tests.
@andreyvelich you're right, it's meant to run E2Es locally. That being said @jaiakash rightly suggested to run the GPU E2E to make sure there is no regression. |
@jaiakash should |
Yes for creating the cluster, One potential issue I foresee is that we're currently configuring the NVIDIA container runtime for Docker:
If we switch the container runtime to Podman, this setup might not work as expected. I was looking into this guide: Podman GPU Support. I will check it tmr morning btw. |
Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
@jaiakash thanks, I've updated it accordingly.
It would be nice if that would work but we don't have to switch the GH Actions E2E workflows to use Podman. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edit. @astefanutti
My bad it got assigned to me, I wanted to just LGTM the PR not assign me. /assign @astefanutti |
@jaiakash thanks. /assign @kubeflow/kubeflow-trainer-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Support setting up e2e cluster with Podman in addition to Docker.
Checklist: