Skip to content

Conversation

@kramaranya
Copy link
Contributor

Since we've moved pyproject.toml to root in kubeflow/sdk#61, I updated its references in Trainer repo

/assign @andreyvelich

Signed-off-by: kramaranya <kramaranya15@gmail.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kramaranya
Copy link
Contributor Author

The tests should be passing after kubeflow/sdk#61 is merged

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16804614421

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 47.949%

Totals Coverage Status
Change from base Build 16792037868: 0.0%
Covered Lines: 947
Relevant Lines: 1975

💛 - Coveralls

@andreyvelich
Copy link
Member

/retest

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Aug 7, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2d4be6f into kubeflow:master Aug 7, 2025
19 of 24 checks passed
@google-oss-prow google-oss-prow bot added this to the v2.1 milestone Aug 7, 2025
@kramaranya
Copy link
Contributor Author

@astefanutti
Copy link
Contributor

/cherry-pick release-2.0

@google-oss-robot
Copy link

@astefanutti: #2780 failed to apply on top of branch "release-2.0":

Applying: fix: update kubeflow sdk reference
Using index info to reconstruct a base tree...
M	.github/workflows/test-e2e.yaml
M	CONTRIBUTING.md
M	examples/deepspeed/text-summarization/T5-Fine-Tuning.ipynb
M	examples/mlx/image-classification/MLX-Distributed-Mnist.ipynb
M	examples/pytorch/image-classification/mnist.ipynb
M	examples/pytorch/question-answering/fine-tune-distilbert.ipynb
M	examples/torchtune/llama3_2/alpaca-trainjob-yaml.ipynb
Falling back to patching base and 3-way merge...
Auto-merging examples/torchtune/llama3_2/alpaca-trainjob-yaml.ipynb
Auto-merging examples/pytorch/question-answering/fine-tune-distilbert.ipynb
CONFLICT (content): Merge conflict in examples/pytorch/question-answering/fine-tune-distilbert.ipynb
Auto-merging examples/pytorch/image-classification/mnist.ipynb
Auto-merging examples/mlx/image-classification/MLX-Distributed-Mnist.ipynb
CONFLICT (content): Merge conflict in examples/mlx/image-classification/MLX-Distributed-Mnist.ipynb
Auto-merging examples/deepspeed/text-summarization/T5-Fine-Tuning.ipynb
CONFLICT (content): Merge conflict in examples/deepspeed/text-summarization/T5-Fine-Tuning.ipynb
Auto-merging CONTRIBUTING.md
Auto-merging .github/workflows/test-e2e.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: update kubeflow sdk reference

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

astefanutti pushed a commit to astefanutti/training-operator that referenced this pull request Sep 23, 2025
Signed-off-by: kramaranya <kramaranya15@gmail.com>
astefanutti pushed a commit to astefanutti/training-operator that referenced this pull request Sep 23, 2025
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
tenzen-y added a commit that referenced this pull request Sep 23, 2025
[release-2.0] fix: update kubeflow sdk reference (#2780)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants