-
Notifications
You must be signed in to change notification settings - Fork 834
fix: update kubeflow sdk reference #2780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update kubeflow sdk reference #2780
Conversation
Signed-off-by: kramaranya <kramaranya15@gmail.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The tests should be passing after kubeflow/sdk#61 is merged |
Pull Request Test Coverage Report for Build 16804614421Details
💛 - Coveralls |
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kramaranya!
Please also update the website: https://www.kubeflow.org/docs/components/trainer/getting-started/#installing-the-kubeflow-python-sdk
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sure, I've updated it in kubeflow/website#4171 |
|
/cherry-pick release-2.0 |
|
@astefanutti: #2780 failed to apply on top of branch "release-2.0": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com> Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
[release-2.0] fix: update kubeflow sdk reference (#2780)
Since we've moved
pyproject.tomlto root in kubeflow/sdk#61, I updated its references in Trainer repo/assign @andreyvelich