Skip to content

Conversation

@runzhen
Copy link
Contributor

@runzhen runzhen commented Feb 6, 2025

What this PR does / why we need it:

The CRD defines the GROUP name is "trainer.kubeflow.org", but in constants.py, GROUP is still "kubeflow.org".
It will cause an error when using the training client.

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Runzhen <wangrunzhen@gmail.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runzhen
Copy link
Contributor Author

runzhen commented Feb 6, 2025

Hi @andreyvelich, could you review or approve this PR ?

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!
I think, we've already change it in this PR: #2415 (comment)

@runzhen
Copy link
Contributor Author

runzhen commented Feb 6, 2025

@andreyvelich yes, I didn't see your PR. Let me close this one, thanks !

@runzhen runzhen closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants