Skip to content

Conversation

@pragyandas
Copy link

@pragyandas pragyandas commented Jan 13, 2025

num_procs_per_worker is no more supported

What this PR does / why we need it:
Fix training example code in documentation

Checklist:

  • Docs included if any changes are user facing

`num_procs_per_worker` is no more supported

Signed-off-by: Pragyan Das <pragyandas@msn.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnugeorge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pragyandas Actually, this is supported as you can see here: https://github.com/kubeflow/training-operator/blob/master/sdk/python/kubeflow/training/api/training_client.py#L348
We just need to release the latest version of SDK to PyPI

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12749103242

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12718184264: 0.0%
Covered Lines: 85
Relevant Lines: 85

💛 - Coveralls

@pragyandas
Copy link
Author

Thanks @andreyvelich! Closing PR

@pragyandas pragyandas closed this Jan 18, 2025
@pragyandas pragyandas deleted the patch-1 branch January 18, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants