Skip to content

Changing image repo from docker.io to ghcr.io #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 30, 2025
Merged

Changing image repo from docker.io to ghcr.io #2483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d41fe35
modified image.registry value
vikas-saxena02 Mar 22, 2025
248898a
modified registry value to ghcr.io
vikas-saxena02 Mar 22, 2025
63a70a9
modified image registry value to ghcr.io
vikas-saxena02 Mar 22, 2025
36085a4
modified image registry_value to ghcr.io
vikas-saxena02 Mar 22, 2025
d284fc3
replaced docker.io with ghcr.io
vikas-saxena02 Mar 22, 2025
a566594
updated container registry credentials
vikas-saxena02 Mar 27, 2025
49f4922
corrected registry username and password
vikas-saxena02 Mar 29, 2025
d69add2
changed image_repo value to inlude controller
vikas-saxena02 Mar 29, 2025
8289d10
removed unwanted space
vikas-saxena02 Mar 29, 2025
6d032d4
Update charts/spark-operator-chart/values.yaml
vikas-saxena02 Mar 29, 2025
c5c2812
Update Makefile
vikas-saxena02 Mar 29, 2025
2cd2430
updated charts/spark-operator-chart/README.md by running make hem-docs
vikas-saxena02 Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ jobs:
- name: Run chart-testing (install)
if: steps.list-changed.outputs.changed == 'true'
run: |
docker build -t docker.io/kubeflow/spark-operator:local .
minikube image load docker.io/kubeflow/spark-operator:local
docker build -t ghcr.io/kubeflow/spark-operator/controller:local .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image hasn't been released yet, has it?

docker pull ghcr.io/kubeflow/spark-operator/controller:2.1.0 Error response from daemon: manifest unknown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturowczarek this is becuase I dont think we had a release since the changed was merged

minikube image load ghcr.io/kubeflow/spark-operator/controller:local
ct install --target-branch ${{ steps.get_branch.outputs.BRANCH }}
e2e-test:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ concurrency:

env:
SEMVER_PATTERN: '^v([0-9]+)\.([0-9]+)\.([0-9]+)(-rc\.([0-9]+))?$'
IMAGE_REGISTRY: docker.io
IMAGE_REPOSITORY: kubeflow/spark-operator
IMAGE_REGISTRY: ghcr.io
IMAGE_REPOSITORY: kubeflow/spark-operator/controller

jobs:
check-release:
Expand Down Expand Up @@ -152,8 +152,8 @@ jobs:
uses: docker/login-action@v3
with:
registry: ${{ env.IMAGE_REGISTRY }}
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push by digest
id: build
Expand Down Expand Up @@ -214,8 +214,8 @@ jobs:
uses: docker/login-action@v3
with:
registry: ${{ env.IMAGE_REGISTRY }}
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Create manifest list and push
working-directory: /tmp/digests
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ UNAME := `uname | tr '[:upper:]' '[:lower:]'`
CONTAINER_TOOL ?= docker

# Image URL to use all building/pushing image targets
IMAGE_REGISTRY ?= docker.io
IMAGE_REPOSITORY ?= kubeflow/spark-operator
IMAGE_REGISTRY ?= ghcr.io
IMAGE_REPOSITORY ?= kubeflow/spark-operator/controller
IMAGE_TAG ?= $(VERSION)
IMAGE ?= $(IMAGE_REGISTRY)/$(IMAGE_REPOSITORY):$(IMAGE_TAG)

Expand Down
4 changes: 2 additions & 2 deletions charts/spark-operator-chart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall) for command docum
| nameOverride | string | `""` | String to partially override release name. |
| fullnameOverride | string | `""` | String to fully override release name. |
| commonLabels | object | `{}` | Common labels to add to the resources. |
| image.registry | string | `"docker.io"` | Image registry. |
| image.repository | string | `"kubeflow/spark-operator"` | Image repository. |
| image.registry | string | `"ghcr.io"` | Image registry. |
| image.repository | string | `"kubeflow/spark-operator/controller"` | Image repository. |
| image.tag | string | If not set, the chart appVersion will be used. | Image tag. |
| image.pullPolicy | string | `"IfNotPresent"` | Image pull policy. |
| image.pullSecrets | list | `[]` | Image pull secrets for private image registry. |
Expand Down
4 changes: 2 additions & 2 deletions charts/spark-operator-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ commonLabels: {}

image:
# -- Image registry.
registry: docker.io
registry: ghcr.io
# -- Image repository.
repository: kubeflow/spark-operator
repository: kubeflow/spark-operator/controller
# -- Image tag.
# @default -- If not set, the chart appVersion will be used.
tag: ""
Expand Down