chore: Add welcome new contributors CI #82

kramaranya · 2025-09-02T17:03:16Z

I added a CI to write a comment to the PRs from new contributors. I'm using https://github.com/actions/first-interaction
An example of this GH action is google/blockly#9250 (review)

I borrowed this idea from Model Registry, thanks @tarilabs!

cc @kubeflow/kubeflow-sdk-team

Signed-off-by: kramaranya <kramaranya15@gmail.com>

coveralls · 2025-09-02T17:04:57Z

Pull Request Test Coverage Report for Build 17445598990

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
73 unchanged lines in 2 files lost coverage.
Overall coverage increased (+5.1%) to 70.146%

Files with Coverage Reduction	New Missed Lines	%
kubeflow/trainer/backends/kubernetes/backend.py	17	78.1%
kubeflow/trainer/utils/utils.py	56	61.88%

Totals
Change from base Build 17382047367:	5.1%
Covered Lines:	289
Relevant Lines:	412

💛 - Coveralls

andreyvelich

That's great idea, thank you for this @kramaranya!
We should also add this for Kubeflow Trainer.
cc @kubeflow/kubeflow-trainer-team @kubeflow/kubeflow-sdk-team @kubeflow/wg-training-leads

andreyvelich · 2025-09-03T15:19:00Z

.github/workflows/welcome-new-contributors.yaml

+            Thanks for opening your first PR! We're happy to have you as part of our community 🚀
+
+            **Here's what happens next:**
+


Maybe it worths to also link the Kubeflow contributor guide, since it explains that commits must be singed: https://www.kubeflow.org/docs/about/contributing/

Good point, let me add this

andreyvelich · 2025-09-03T15:20:14Z

.github/workflows/welcome-new-contributors.yaml

+
+            **Here's what happens next:**
+
+            - If you haven't already, please check out our [Contributing Guide](https://github.com/kubeflow/sdk/blob/main/CONTRIBUTING.md)


Shall we also encourage them to join Kubeflow Slack channels (e.g. #kubeflow-trainer and #kubeflow-ml-experience) and community calls ?

Sure, I'll update it!
However I think we should just refer to #kubeflow-ml-experience, wdyt?

From my point of view, it would be beneficial for contributors to join both of these channels, since Kubeflow SDK will affect many Kubeflow projects.

Yeah, but in this case will we need to also add Slack channels for model registry, pipelines, katib etc?

Let's add them once we support it in Kubeflow SDK ?

I meant do we actually want to explicitly point to each project's slack channel? If we list multiple channels, it might confuse new contributors about where to start or which channel to use for what.

I'll add trainer to the list, but in the future (same in README) maybe we could point to #kubeflow-ml-experience as the primary channel and add a note that contributors should also join other project specific channels (like trainer, pipelines) if they're working on features that touch those components?

Sure, we can do that.

If they're working on features that touch those components?

In any case, contributors will work on features that touch some Kubeflow sub-projects, so they should be aware of the development.

andreyvelich · 2025-09-03T15:21:06Z

.github/workflows/welcome-new-contributors.yaml

+    permissions:
+      pull-requests: write
+    steps:
+      - uses: actions/first-interaction@v3


Do you know how it detects the first interaction ? Does it check how many PRs user opens ?

I don't know for sure, I think it just checks whether the PR author has ever opened a PR here before https://github.com/actions/first-interaction/tree/main?tab=readme-ov-file#first-interaction
and just hope it'll work... :)

Signed-off-by: kramaranya <kramaranya15@gmail.com>

andreyvelich

Thank you @kramaranya!
If you can create similar action in KF Trainer, that would be great!
/lgtm
/assign @kubeflow/kubeflow-sdk-team

kramaranya · 2025-09-05T08:03:14Z

If you can create similar action in KF Trainer, that would be great!

Sure, I will! Let's just first ensure it works :)

Electronic-Waste

@kramaranya Thanks for this great contribution. LGTM!

/lgtm

andreyvelich

/approve

google-oss-prow · 2025-09-07T22:32:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* chore: Add welcome new contributors CI Signed-off-by: kramaranya <kramaranya15@gmail.com> * Add community links to welcome CI Signed-off-by: kramaranya <kramaranya15@gmail.com> * Add slack channels to CI Signed-off-by: kramaranya <kramaranya15@gmail.com> --------- Signed-off-by: kramaranya <kramaranya15@gmail.com>

chore: Add welcome new contributors CI

362617c

Signed-off-by: kramaranya <kramaranya15@gmail.com>

google-oss-prow bot requested review from andreyvelich, astefanutti and szaher September 2, 2025 17:03

google-oss-prow bot added the size/S label Sep 2, 2025

andreyvelich reviewed Sep 3, 2025

View reviewed changes

Add community links to welcome CI

7e58dbd

Signed-off-by: kramaranya <kramaranya15@gmail.com>

google-oss-prow bot added size/M and removed size/S labels Sep 3, 2025

Add slack channels to CI

c8c0d3b

Signed-off-by: kramaranya <kramaranya15@gmail.com>

andreyvelich reviewed Sep 4, 2025

View reviewed changes

google-oss-prow bot assigned andreyvelich Sep 4, 2025

google-oss-prow bot added the lgtm label Sep 4, 2025

Electronic-Waste reviewed Sep 6, 2025

View reviewed changes

google-oss-prow bot assigned Electronic-Waste Sep 6, 2025

andreyvelich reviewed Sep 7, 2025

View reviewed changes

google-oss-prow bot added the approved label Sep 7, 2025

google-oss-prow bot merged commit d5c60f5 into kubeflow:main Sep 7, 2025
10 checks passed

google-oss-prow bot added this to the v0.1 milestone Sep 7, 2025

		Thanks for opening your first PR! We're happy to have you as part of our community 🚀

		Here's what happens next:


		Here's what happens next:

		- If you haven't already, please check out our [Contributing Guide](https://github.com/kubeflow/sdk/blob/main/CONTRIBUTING.md)

Uh oh!

chore: Add welcome new contributors CI #82

chore: Add welcome new contributors CI #82

Uh oh!

Conversation

kramaranya commented Sep 2, 2025

Uh oh!

coveralls commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 17445598990

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

andreyvelich left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreyvelich left a comment

Choose a reason for hiding this comment

Uh oh!

kramaranya commented Sep 5, 2025

Uh oh!

Electronic-Waste left a comment

Choose a reason for hiding this comment

Uh oh!

andreyvelich left a comment

Choose a reason for hiding this comment

Uh oh!

google-oss-prow bot commented Sep 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Sep 2, 2025 •

edited

Loading