Skip to content

Conversation

@andreyvelich
Copy link
Member

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@andreyvelich andreyvelich changed the title Nominate @kramaranya and @szaher as Kubeflow SDK reviewers chore: Nominate @kramaranya and @szaher as Kubeflow SDK reviewers Aug 29, 2025
@coveralls
Copy link

coveralls commented Aug 29, 2025

Pull Request Test Coverage Report for Build 17327959359

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.033%

Totals Coverage Status
Change from base Build 17296779530: 0.0%
Covered Lines: 292
Relevant Lines: 449

💛 - Coveralls

@astefanutti
Copy link
Contributor

+1

@kramaranya @szaher congratulations and thanks a lot for all your contributions!

@andreyvelich
Copy link
Member Author

cc @kubeflow/wg-training-leads for visibility

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -1,7 +1,9 @@
approvers:
- andreyvelich
- astefanutti
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase once the other PR is merged

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this OWNER file is for Kubeflow SDK, not for Kubeflow Trainer.

@kramaranya
Copy link
Contributor

Thanks a lot, @andreyvelich!
I'm thrilled to be part of this community and continue collaborating with all of you!

@andreyvelich
Copy link
Member Author

Thanks everyone!
/hold cancel

@andreyvelich
Copy link
Member Author

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3bd3cd9 into kubeflow:main Sep 1, 2025
9 of 10 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.1 milestone Sep 1, 2025
@andreyvelich andreyvelich deleted the update-approvers branch September 1, 2025 12:21
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kramaranya @szaher Well deserved! Looking forward to working with you in the future!

accorvin pushed a commit to opendatahub-io/kubeflow-sdk that referenced this pull request Oct 8, 2025
…beflow#76)

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants