-
Couldn't load subscription status.
- Fork 43
chore: Nominate @kramaranya and @szaher as Kubeflow SDK reviewers #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Pull Request Test Coverage Report for Build 17327959359Details
💛 - Coveralls |
|
+1 @kramaranya @szaher congratulations and thanks a lot for all your contributions! |
|
cc @kubeflow/wg-training-leads for visibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
| @@ -1,7 +1,9 @@ | |||
| approvers: | |||
| - andreyvelich | |||
| - astefanutti | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to rebase once the other PR is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this OWNER file is for Kubeflow SDK, not for Kubeflow Trainer.
|
Thanks a lot, @andreyvelich! |
|
Thanks everyone! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kramaranya @szaher Well deserved! Looking forward to working with you in the future!
…beflow#76) Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
I would like to nominate @kramaranya and @szaher as Kubeflow SDK reviewers.
Both of them are actively involved in the development, and they fit the requirements: https://www.kubeflow.org/docs/about/membership/#reviewer
Thank you for your contributions to Kubeflow SDK 🎉
/hold for @astefanutti @Electronic-Waste +1