-
Couldn't load subscription status.
- Fork 43
chore: Remove tool.hatch.build.targets from pyproject #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Pull Request Test Coverage Report for Build 17294910153Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 17294910153Details
💛 - Coveralls |
|
/lgtm Thanks @kramaranya. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kramaranya!
You might want to delete it from the modules as well: https://github.com/kubeflow/trainer/blob/master/api/python_api/pyproject.toml#L38-L39
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kramaranya <kramaranya15@gmail.com>
What this PR does / why we need it:
I removed the redundant hatch build target from pyproject.toml
The old table
[tool.hatch.build.targets]is not correct, it's supposed to be in[tool.hatch.build.targets.wheel]instead -- https://hatch.pypa.io/1.9/config/build/#packagesBut since we have a single package, I’m not adding
[tool.hatch.build.targets.wheel]either, because hatchling finds the package on its own -- https://hatch.pypa.io/1.9/plugins/builder/wheel/#default-file-selection/assign @andreyvelich @astefanutti @Electronic-Waste