chore: Add proper ruff configuration #69
Merged
+677
−602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper ruff configuration to * support proper linting * support ruff format * support isort with ruff * update pre-commit configs Signed-off-by: Saad Zaher <eng.szaher@gmail.com>
google-oss-prow
bot
requested review from
Electronic-Waste,
andreyvelich and
astefanutti
|
I'll be fixing issues in this PR later after merging local execution PRs #68 |
1 task
|
@szaher Can you rebase this PR, so we can have the valid ruff linter ? |
Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
|
/unhold |
Signed-off-by: Saad Zaher <szaher@redhat.com>
remove reduandant `uv sync` Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Saad Zaher <szaher@redhat.com>
add labels next to linters codes Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
There was a problem hiding this comment.
Thanks @szaher!
/lgtm
/assign @Electronic-Waste @kramaranya @astefanutti
google-oss-prow
bot
assigned
astefanutti,
Electronic-Waste,
kramaranya and
andreyvelich
Signed-off-by: Saad Zaher <szaher@redhat.com>
|
/lgtm |
1 task
astefanutti
reviewed
Sep 15, 2025
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
accorvin
pushed a commit
to opendatahub-io/kubeflow-sdk
that referenced
this pull request
Oct 8, 2025
* chore: Add proper ruff configuration Add proper ruff configuration to * support proper linting * support ruff format * support isort with ruff * update pre-commit configs Signed-off-by: Saad Zaher <eng.szaher@gmail.com> * merge with main Signed-off-by: Saad Zaher <szaher@redhat.com> * fix format Signed-off-by: Saad Zaher <szaher@redhat.com> * fix linting issues Signed-off-by: Saad Zaher <szaher@redhat.com> * Update Makefile remove reduandant `uv sync` Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Saad Zaher <szaher@redhat.com> * let linter handle line-length \n add labels next to linters codes Signed-off-by: Saad Zaher <szaher@redhat.com> * remove duplicate labels from linter Signed-off-by: Saad Zaher <szaher@redhat.com> * remove unwanted comment in pyproject.toml Signed-off-by: Saad Zaher <szaher@redhat.com> --------- Signed-off-by: Saad Zaher <eng.szaher@gmail.com> Signed-off-by: Saad Zaher <szaher@redhat.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
MStokluska
pushed a commit
to opendatahub-io/kubeflow-sdk
that referenced
this pull request
Oct 15, 2025
* chore: Add proper ruff configuration Add proper ruff configuration to * support proper linting * support ruff format * support isort with ruff * update pre-commit configs Signed-off-by: Saad Zaher <eng.szaher@gmail.com> * merge with main Signed-off-by: Saad Zaher <szaher@redhat.com> * fix format Signed-off-by: Saad Zaher <szaher@redhat.com> * fix linting issues Signed-off-by: Saad Zaher <szaher@redhat.com> * Update Makefile remove reduandant `uv sync` Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Saad Zaher <szaher@redhat.com> * let linter handle line-length \n add labels next to linters codes Signed-off-by: Saad Zaher <szaher@redhat.com> * remove duplicate labels from linter Signed-off-by: Saad Zaher <szaher@redhat.com> * remove unwanted comment in pyproject.toml Signed-off-by: Saad Zaher <szaher@redhat.com> --------- Signed-off-by: Saad Zaher <eng.szaher@gmail.com> Signed-off-by: Saad Zaher <szaher@redhat.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
MStokluska
pushed a commit
to opendatahub-io/kubeflow-sdk
that referenced
this pull request
Oct 15, 2025
* chore: Add proper ruff configuration Add proper ruff configuration to * support proper linting * support ruff format * support isort with ruff * update pre-commit configs Signed-off-by: Saad Zaher <eng.szaher@gmail.com> * merge with main Signed-off-by: Saad Zaher <szaher@redhat.com> * fix format Signed-off-by: Saad Zaher <szaher@redhat.com> * fix linting issues Signed-off-by: Saad Zaher <szaher@redhat.com> * Update Makefile remove reduandant `uv sync` Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Saad Zaher <szaher@redhat.com> * let linter handle line-length \n add labels next to linters codes Signed-off-by: Saad Zaher <szaher@redhat.com> * remove duplicate labels from linter Signed-off-by: Saad Zaher <szaher@redhat.com> * remove unwanted comment in pyproject.toml Signed-off-by: Saad Zaher <szaher@redhat.com> --------- Signed-off-by: Saad Zaher <eng.szaher@gmail.com> Signed-off-by: Saad Zaher <szaher@redhat.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add proper ruff configuration to
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: