-
Couldn't load subscription status.
- Fork 43
fix(trainer): Keep the original runtime command in get_runtime_packages() API #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(trainer): Keep the original runtime command in get_runtime_packages() API #64
Conversation
…ckages() API Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Pull Request Test Coverage Report for Build 17055450797Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 17055450797Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 17055450797Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreyvelich Thanks for this!
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Electronic-Waste The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…es() API (kubeflow#64) Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
We should not modify the runtime's trainer command when user calls
get_runtime_packages()API./assign @kubeflow/wg-training-leads @astefanutti @kramaranya @szaher