Skip to content

Conversation

@andreyvelich
Copy link
Member

As we discussed in this thread: #31 (comment), I will remove the accelerator label from the runtime for now.

In the future we can find better way to detect accelerator of runtime if that is required.

/assign @astefanutti @Electronic-Waste @szaher @kramaranya @eoinfennessy

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@google-oss-prow
Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: eoinfennessy, szaher.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

As we discussed in this thread: #31 (comment), I will remove the accelerator label from the runtime for now.

In the future we can find better way to detect accelerator of runtime if that is required.

/assign @astefanutti @Electronic-Waste @szaher @kramaranya @eoinfennessy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16556432487

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 64.567%

Totals Coverage Status
Change from base Build 16463414499: -0.2%
Covered Lines: 246
Relevant Lines: 381

💛 - Coveralls

@astefanutti
Copy link
Contributor

/lgtm

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Jul 28, 2025
Copy link
Member Author

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 64d74db into kubeflow:main Jul 28, 2025
8 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.1 milestone Jul 28, 2025
@andreyvelich andreyvelich deleted the remove-accelerator-type branch July 28, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants