-
Notifications
You must be signed in to change notification settings - Fork 41
Allow CustomTrainer to run a Python script directly via python_file #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jskswamy
wants to merge
8
commits into
kubeflow:main
Choose a base branch
from
jskswamy:feature/customtrainer-python-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+410
−16
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1fe9e5f
Add CommandTrainer dataclass and update utils
jskswamy b92cc8b
Implement Trainer CRD construction for CommandTrainer
jskswamy a51b0e4
Validate CommandTrainer Integration in Backend
jskswamy 763e39f
Document usage of CommandTrainer in README
jskswamy 994a8c3
Update TrainerClient and KubernetesBackend to support CommandTrainer
jskswamy f1eea03
Update CommandTrainer to Support Optional Command
jskswamy bc7fd32
Update CommandTrainer to Support Extra Pip Args
jskswamy b06bb29
Ensure consistent bash-wrapping for commands
jskswamy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| from kubeflow.trainer.types import types | ||
|
|
||
|
|
||
| class TestCommandTrainerType: | ||
| def test_command_trainer_dataclass_minimal(self): | ||
| trainer = types.CommandTrainer(command=["python"], args=["train.py"]) | ||
|
|
||
| assert trainer.command == ["python"] | ||
| assert trainer.args == ["train.py"] | ||
| assert trainer.pip_index_urls and isinstance(trainer.pip_index_urls, list) | ||
| assert trainer.packages_to_install is None | ||
| assert trainer.env is None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting idea and somewhat aligned with what we discussed today at the Kubeflow SDK call with
KubernetesTrainerproposed by @szaher: https://youtu.be/mv8GoWdefck?t=832Since we distinguish the runtime trainers between CustomTrainer and BuiltinTrainer, I am wondering if we want to introduce
CustomTrainerContainer()type which give users control to configureimage,container,argsinstead of passing the training function.Would that be helpful for integration between KFP and Trainer ?
Thoughts @kubeflow/kubeflow-sdk-team @mprahl @franciscojavierarceo @ederign @rudeigerc?