Skip to content

Conversation

@briangallagher
Copy link
Contributor

What this PR does / why we need it:
Add some initial unit tests for trainer_client.py

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #16

Checklist:

  • Docs included if any changes are user facing

@briangallagher briangallagher force-pushed the unit-test branch 3 times, most recently from fe5b042 to d131e3e Compare June 6, 2025 15:45
Copy link
Member

@eoinfennessy eoinfennessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very quick review, but this looks great.

I will have a proper look tomorrow.

Copy link
Contributor

@kramaranya kramaranya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We create new mock objects every test run, for example get_mock_pod_list and create_cluster_training_runtime. Can we maybe create them once per session and reuse them?
Other than that looks great! Thank you!

@briangallagher briangallagher force-pushed the unit-test branch 2 times, most recently from 98b38af to 2ccc5b6 Compare June 13, 2025 11:35
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

/approve
Leaving /lgtm on @kramaranya @Electronic-Waste

@andreyvelich
Copy link
Member

Thank you for this @briangallagher!
let me take a look at this early next week.
/hold
/assign @andreyvelich

Signed-off-by: Brian Gallagher <briangal@gmail.com>
Signed-off-by: Brian Gallagher <briangal@gmail.com>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @briangallagher!
Overall, lgtm, just small comments.

briangallagher and others added 3 commits July 17, 2025 08:46
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Brian Gallagher <briangal@gmail.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Brian Gallagher <briangal@gmail.com>
Signed-off-by: Brian Gallagher <briangal@gmail.com>
Signed-off-by: Brian Gallagher <briangal@gmail.com>
@andreyvelich
Copy link
Member

/ok-to-test

Signed-off-by: Brian Gallagher <briangal@gmail.com>
Signed-off-by: Brian Gallagher <briangal@gmail.com>
Signed-off-by: Brian Gallagher <briangal@gmail.com>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this amazing contribution @briangallagher!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 17, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

/hold cancel

@google-oss-prow google-oss-prow bot merged commit cb6e597 into kubeflow:main Jul 18, 2025
7 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.1 milestone Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit test for trainer_client.py

6 participants