-
Notifications
You must be signed in to change notification settings - Fork 41
add unit test for trainer sdk #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe5b042 to
d131e3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very quick review, but this looks great.
I will have a proper look tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We create new mock objects every test run, for example get_mock_pod_list and create_cluster_training_runtime. Can we maybe create them once per session and reuse them?
Other than that looks great! Thank you!
98b38af to
2ccc5b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
/approve
Leaving /lgtm on @kramaranya @Electronic-Waste
|
Thank you for this @briangallagher! |
Signed-off-by: Brian Gallagher <briangal@gmail.com>
2ccc5b6 to
35399e2
Compare
cd37cbd to
9553054
Compare
Signed-off-by: Brian Gallagher <briangal@gmail.com>
9553054 to
ba64f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @briangallagher!
Overall, lgtm, just small comments.
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Brian Gallagher <briangal@gmail.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Brian Gallagher <briangal@gmail.com>
Signed-off-by: Brian Gallagher <briangal@gmail.com>
Signed-off-by: Brian Gallagher <briangal@gmail.com>
|
/ok-to-test |
120159e to
131a37e
Compare
Signed-off-by: Brian Gallagher <briangal@gmail.com>
131a37e to
3082874
Compare
708f4a0 to
c87e53c
Compare
Signed-off-by: Brian Gallagher <briangal@gmail.com>
c87e53c to
cf57339
Compare
Signed-off-by: Brian Gallagher <briangal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this amazing contribution @briangallagher!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
What this PR does / why we need it:
Add some initial unit tests for trainer_client.py
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #16
Checklist: