Skip to content

feat: Add ContainerBackend with Docker and Podman #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+3,000 −118
Open

feat: Add ContainerBackend with Docker and Podman #119

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1188510
Add docker backend
briangallagher Sep 29, 2025
60fd258
Add podman backend
Fiona-Waters Oct 3, 2025
d1288b2
Implementing ContainerBackend
Fiona-Waters Oct 9, 2025
0680c3e
Use ip address for Podman
Fiona-Waters Oct 14, 2025
24f0bbd
Updating to rely on container runtime rather than storing job info in…
Fiona-Waters Oct 20, 2025
a9218c5
Addressing feedback
Fiona-Waters Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions kubeflow/trainer/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

# Import the Kubeflow Trainer client.
from kubeflow.trainer.api.trainer_client import TrainerClient # noqa: F401
from kubeflow.trainer.backends.docker.types import LocalDockerBackendConfig
from kubeflow.trainer.backends.podman.types import LocalPodmanBackendConfig

# import backends and its associated configs
from kubeflow.trainer.backends.kubernetes.types import KubernetesBackendConfig
Expand Down Expand Up @@ -58,5 +60,7 @@
"TrainerClient",
"TrainerType",
"LocalProcessBackendConfig",
"LocalDockerBackendConfig",
"LocalPodmanBackendConfig",
"KubernetesBackendConfig",
]
15 changes: 14 additions & 1 deletion kubeflow/trainer/api/trainer_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
import logging
from typing import Optional, Union

from kubeflow.trainer.backends.docker.backend import LocalDockerBackend
from kubeflow.trainer.backends.docker.types import LocalDockerBackendConfig
from kubeflow.trainer.backends.podman.backend import LocalPodmanBackend
from kubeflow.trainer.backends.podman.types import LocalPodmanBackendConfig
from kubeflow.trainer.backends.kubernetes.backend import KubernetesBackend
from kubeflow.trainer.backends.kubernetes.types import KubernetesBackendConfig
from kubeflow.trainer.backends.localprocess.backend import (
Expand All @@ -31,7 +35,12 @@
class TrainerClient:
def __init__(
self,
backend_config: Union[KubernetesBackendConfig, LocalProcessBackendConfig] = None,
backend_config: Union[
KubernetesBackendConfig,
LocalProcessBackendConfig,
LocalDockerBackendConfig,
LocalPodmanBackendConfig,
] = None,
):
"""Initialize a Kubeflow Trainer client.

Expand All @@ -52,6 +61,10 @@ def __init__(
self.backend = KubernetesBackend(backend_config)
elif isinstance(backend_config, LocalProcessBackendConfig):
self.backend = LocalProcessBackend(backend_config)
elif isinstance(backend_config, LocalDockerBackendConfig):
self.backend = LocalDockerBackend(backend_config)
elif isinstance(backend_config, LocalPodmanBackendConfig):
self.backend = LocalPodmanBackend(backend_config)
else:
raise ValueError(f"Invalid backend config '{backend_config}'")

Expand Down
Loading
Loading