Skip to content

feat(trainer): KEP-2655: Support provisioning of cache with Kubeflow SDK #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

feat(trainer): KEP-2655: Support provisioning of cache with Kubeflow SDK #112

merged 1 commit into from
Oct 20, 2025
+252 −30

Conversation

@akshaychitneni
Copy link
Contributor

What this PR does / why we need it:
Adds cache initializer in sdk

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes # kubeflow/trainer#2866

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Sep 30, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18640430462

Details

  • 14 of 17 (82.35%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 73.409%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kubeflow/trainer/utils/utils.py 14 17 82.35%
Totals Coverage Status
Change from base Build 18532331365: 1.0%
Covered Lines: 323
Relevant Lines: 440
💛 - Coveralls

andreyvelich
andreyvelich reviewed Oct 6, 2025
View reviewed changes
@andreyvelich
Copy link
Member

/milestone v0.2

@google-oss-prow google-oss-prow bot added this to the v0.2 milestone Oct 8, 2025
@andreyvelich
Copy link
Member

@akshaychitneni Since we merged this PR, did you get a chance to review the rest comments: kubeflow/trainer#2793 ?

@akshaychitneni
Copy link
Contributor Author

@akshaychitneni Since we merged this PR, did you get a chance to review the rest comments: kubeflow/trainer#2793 ?

Yes, I should have addressed the comments. Let me work on tests

@akshaychitneni akshaychitneni force-pushed the cache branch 2 times, most recently from 0aa49d5 to 6d584b7 Compare October 16, 2025 18:17
@akshaychitneni akshaychitneni changed the title feat(cache): KEP-2655: Support provisioning of cache with Kubeflow SDK feat(trainer): KEP-2655: Support provisioning of cache with Kubeflow SDK Oct 16, 2025
andreyvelich
andreyvelich reviewed Oct 16, 2025
View reviewed changes
@akshaychitneni akshaychitneni force-pushed the cache branch 3 times, most recently from ea98502 to eb88829 Compare October 16, 2025 21:02
andreyvelich
andreyvelich reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @akshaychitneni!
/lgtm
/assign @szaher @kramaranya @Electronic-Waste @astefanutti

@google-oss-prow google-oss-prow bot added the lgtm label Oct 16, 2025
@google-oss-prow google-oss-prow bot removed the lgtm label Oct 16, 2025
Electronic-Waste
Electronic-Waste reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshaychitneni Thanks for this. Just a few nits

@akshaychitneni akshaychitneni force-pushed the cache branch 2 times, most recently from 4ef82cf to 6814b18 Compare October 17, 2025 21:12
andreyvelich
andreyvelich reviewed Oct 18, 2025
View reviewed changes
feat(trainer): KEP-2655: Adding cache initializer
28c74f9 
Signed-off-by: Akshay Chitneni <achitneni@apple.com>
andreyvelich
andreyvelich reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @akshaychitneni!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Oct 20, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 250dc13 into kubeflow:main Oct 20, 2025
10 checks passed
@andreyvelich andreyvelich mentioned this pull request Oct 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@kramaranya kramaranya Awaiting requested review from kramaranya

@szaher szaher Awaiting requested review from szaher

+1 more reviewer

@Electronic-Waste Electronic-Waste Electronic-Waste left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@astefanutti astefanutti

@szaher szaher

@andreyvelich andreyvelich

@kramaranya kramaranya

@Electronic-Waste Electronic-Waste

Labels

approved lgtm size/L

Projects

None yet

Milestone

v0.2

Development

Successfully merging this pull request may close these issues.

7 participants

@akshaychitneni @coveralls @andreyvelich @Electronic-Waste @astefanutti @szaher @kramaranya