-
Notifications
You must be signed in to change notification settings - Fork 1k
Feature: Add Istio Ambient Mode Support via Overlay Method #3246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
madmecodes
wants to merge
23
commits into
kubeflow:master
Choose a base branch
from
madmecodes:ambient-overlay
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+477
−42
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7d6b5da
feature: ambient with overlay method
madmecodes cc7d872
update: remove empty line minor formatting issue
madmecodes 4e15ab9
update: remove duplication and use inheritance for gke overlay in amb…
madmecodes c81d883
update: remove common env variables already in base
madmecodes eb5e10b
feat: using components approach to enable ambient-mode and gke specif…
madmecodes d8795df
added ambient workflow to test in kind cluster
madmecodes 0e7ea54
feat: add Istio Ambient Mode with PSS baseline requirement
madmecodes fbc3d8c
update: ambient pss upgraded to privilidged
madmecodes 2541535
upate: cni ztunnel connection debug
madmecodes f009b25
fix: enable ambient mode in CNI
madmecodes 29a7b11
fix: workflow updates from baseline to privilidged
madmecodes 984eae4
fix: ambient netns mount, rbac fix
madmecodes 2583800
fix: ambient netns mount, rbac fix2
madmecodes 917ed43
fix: remove duplication for ambient-oauth2-proxy
madmecodes c578b30
update: workflow added in matrix
madmecodes 438f881
fix: workflow matrix fix order
madmecodes 6902821
update: gke-cni component created and remove duplicacy
madmecodes 39f8b42
fix: corrected file name from baseline to privileged
madmecodes caf196a
fix: remove unwanted echo
madmecodes f477654
Update common/istio/README.md
juliusvonkohout 6ea7550
Delete common/istio/istio-install/components/ambient-mode/istio-names…
juliusvonkohout daade68
Update common/istio/README.md
juliusvonkohout f1e274b
Update kustomization.yaml
juliusvonkohout File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
common/istio/istio-install/components/ambient-mode/cni-ambient-patch.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
apiVersion: apps/v1 | ||
kind: DaemonSet | ||
metadata: | ||
name: istio-cni-node | ||
namespace: kube-system | ||
spec: | ||
template: | ||
spec: | ||
containers: | ||
- name: install-cni | ||
volumeMounts: | ||
- mountPath: /var/run/ztunnel | ||
name: cni-ztunnel-sock-dir | ||
- mountPath: /host/var/run/netns | ||
name: cni-netns-dir | ||
mountPropagation: HostToContainer | ||
volumes: | ||
- name: cni-ztunnel-sock-dir | ||
hostPath: | ||
path: /var/run/ztunnel | ||
type: DirectoryOrCreate |
7 changes: 7 additions & 0 deletions
7
common/istio/istio-install/components/ambient-mode/cni-config-patch.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: istio-cni-config | ||
namespace: kube-system | ||
data: | ||
AMBIENT_ENABLED: "true" |
18 changes: 18 additions & 0 deletions
18
common/istio/istio-install/components/ambient-mode/cni-rbac-patch.yaml
juliusvonkohout marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: ClusterRole | ||
metadata: | ||
name: istio-cni | ||
rules: | ||
- apiGroups: | ||
- "" | ||
resources: | ||
- pods | ||
- pods/status | ||
- nodes | ||
- namespaces | ||
verbs: | ||
- get | ||
- list | ||
- watch | ||
- patch | ||
- update |
6 changes: 6 additions & 0 deletions
6
common/istio/istio-install/components/ambient-mode/istio-namespace-pss-privileged.yaml
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we deploy Ztunnel in another namespace called istio-ztunnel or so? So separate and isolated ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See also #3246 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
apiVersion: v1 | ||
kind: Namespace | ||
metadata: | ||
name: istio-system | ||
labels: | ||
pod-security.kubernetes.io/enforce: privileged |
13 changes: 13 additions & 0 deletions
13
common/istio/istio-install/components/ambient-mode/istiod-ambient-patch.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
apiVersion: apps/v1 | ||
kind: Deployment | ||
metadata: | ||
name: istiod | ||
namespace: istio-system | ||
spec: | ||
template: | ||
spec: | ||
containers: | ||
- name: discovery | ||
env: | ||
- name: PILOT_ENABLE_AMBIENT | ||
value: "true" |
34 changes: 34 additions & 0 deletions
34
common/istio/istio-install/components/ambient-mode/kustomization.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
apiVersion: kustomize.config.k8s.io/v1alpha1 | ||
kind: Component | ||
|
||
resources: | ||
- ztunnel.yaml | ||
- istio-namespace-pss-privileged.yaml | ||
|
||
patches: | ||
- path: istiod-ambient-patch.yaml | ||
target: | ||
kind: Deployment | ||
name: istiod | ||
namespace: istio-system | ||
- path: cni-ambient-patch.yaml | ||
target: | ||
kind: DaemonSet | ||
name: istio-cni-node | ||
namespace: kube-system | ||
- path: cni-config-patch.yaml | ||
target: | ||
kind: ConfigMap | ||
name: istio-cni-config | ||
namespace: kube-system | ||
- path: cni-rbac-patch.yaml | ||
target: | ||
kind: ClusterRole | ||
name: istio-cni | ||
- target: | ||
kind: Namespace | ||
name: kubeflow | ||
patch: |- | ||
- op: add | ||
path: /metadata/labels/istio.io~1dataplane-mode | ||
value: ambient |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.