Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/helm-kustomize-comparison.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ jobs:
env:
VERBOSE: "true"
run: |
./tests/helm_kustomize_compare_all.sh model-registry
./tests/helm_kustomize_compare_all.sh
52 changes: 0 additions & 52 deletions .github/workflows/katib-helm-kustomize-comparison.yaml

This file was deleted.

50 changes: 0 additions & 50 deletions .github/workflows/kserve-models-web-app-comparison.yml

This file was deleted.

6 changes: 6 additions & 0 deletions experimental/helm/charts/notebook-controller/.helmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Minimal .helmignore for debugging
.DS_Store
*.swp
*.bak
*.tmp
.git/
19 changes: 19 additions & 0 deletions experimental/helm/charts/notebook-controller/Chart.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
apiVersion: v2
name: notebook-controller
description: A Helm chart for Kubeflow Notebook Controller - Jupyter notebook management on Kubernetes
version: 1.10.0
appVersion: v1.10.0
keywords:
- kubeflow
- jupyter
- notebooks
- machine-learning
- controller
home: https://github.com/kubeflow/kubeflow
icon: https://www.kubeflow.org/images/logo.svg
sources:
- https://github.com/kubeflow/kubeflow
- https://github.com/kubeflow/manifests
annotations:
category: Machine Learning
licenses: Apache-2.0
99 changes: 99 additions & 0 deletions experimental/helm/charts/notebook-controller/ci/base-values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
# Values for base deployment mode
deploymentMode: standalone

# Override names
nameOverride: ""
fullnameOverride: ""

global:
namespace: notebook-controller-system
imageRegistry: ghcr.io/kubeflow/kubeflow
imageTag: v1.10.0

# Common labels
commonLabels:
app: notebook-controller
kustomize.component: notebook-controller

controller:
config:
useIstio: true
istioGateway: "kubeflow/kubeflow-gateway"
istioHost: "*"
clusterDomain: "cluster.local"
enableCulling: false
cullIdleTime: "1440"
idlenessCheckPeriod: "1"

manager:
enableLeaderElection: true
metricsAddr: "0.0.0.0:8080"
healthProbeAddr: ":8081"

# Disable auth proxy in base mode
authProxy:
enabled: false

# Webhook disabled by default
webhook:
enabled: false

# Security context
podSecurityContext:
seccompProfile:
type: RuntimeDefault

securityContext:
runAsNonRoot: true
allowPrivilegeEscalation: false
runAsUser: 1000
capabilities:
drop:
- ALL

# Enable main service
service:
enabled: true
type: ClusterIP
port: 443

# Disable metrics service in base (no auth proxy)
metricsService:
enabled: false

# RBAC
rbac:
create: true
serviceAccount:
create: true
name: ""
authProxy:
enabled: false
leaderElection:
enabled: true

# Enable direct metrics without auth proxy
monitoring:
enabled: true
prometheus:
enabled: true
podAnnotations:
prometheus.io/scrape: "true"
prometheus.io/port: "8080"
prometheus.io/path: "/metrics"

# CRD management with patches
crds:
install: true
validationPatches:
enabled: true

kustomizeMode:
enabled: true
useOriginalLabels: true
useOriginalNames: true

# Disable samples
samples:
enabled: false
namespace: "default"
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
# Values for Kubeflow deployment mode
deploymentMode: kubeflow

nameOverride: "notebook-controller"

global:
namespace: kubeflow
imageRegistry: ghcr.io/kubeflow/kubeflow
imageTag: v1.10.0

# Common labels
commonLabels:
app: notebook-controller
kustomize.component: notebook-controller

controller:
config:
useIstio: true
istioGateway: "kubeflow/kubeflow-gateway"
istioHost: "*"
clusterDomain: "cluster.local"
enableCulling: false
cullIdleTime: "1440"
idlenessCheckPeriod: "1"

manager:
enableLeaderElection: true
metricsAddr: "127.0.0.1:8080"
healthProbeAddr: ":8081"

# Disable auth proxy
authProxy:
enabled: false

# Webhook server disabled by default
webhook:
enabled: false

# Security context
podSecurityContext:
seccompProfile:
type: RuntimeDefault

securityContext:
runAsNonRoot: true
allowPrivilegeEscalation: false
runAsUser: 1000
capabilities:
drop:
- ALL

# Enable main service (matches manager/service.yaml)
service:
enabled: true
type: ClusterIP
port: 443

# Disable metrics service
metricsService:
enabled: false

# RBAC
rbac:
create: true
serviceAccount:
create: true
name: ""
authProxy:
enabled: false
leaderElection:
enabled: true

# Enable monitoring with proper annotations
monitoring:
enabled: true
prometheus:
enabled: true

# CRD management with patches
crds:
install: true
validationPatches:
enabled: true

# Kustomize compatibility for Kubeflow
kustomizeMode:
enabled: true
useOriginalLabels: true
useOriginalNames: true

# Disable samples in production Kubeflow
samples:
enabled: false
Loading
Loading