Skip to content

Conversation

tarilabs
Copy link
Member

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

periodic sync

📦 Dependencies

n/a

🐛 Related Issues

n/a

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@tarilabs
Copy link
Member Author

@juliusvonkohout can you kindly advise as part of manifest syncing with script, what other manual action are required when submitting a PR for manifest syncing now please?

@juliusvonkohout
Copy link
Member

@kunal-511 please help out here and adjust the helm chart. Can we make the helm tests non-blocking ?

@kunal-511
Copy link
Contributor

kunal-511 commented Aug 12, 2025

we can comment out this - 'applications/model-registry/**' and this - '.github/workflows/helm-kustomize-comparison.yml'
from https://github.com/kubeflow/manifests/blob/ac32b09acd3afeaa2b9a16e3c0a8943f5ded2496/.github/workflows/helm-kustomize-comparison.yml

@juliusvonkohout
Copy link
Member

we can comment out this - 'applications/model-registry/**' and this - '.github/workflows/helm-kustomize-comparison.yml' from https://github.com/kubeflow/manifests/blob/ac32b09acd3afeaa2b9a16e3c0a8943f5ded2496/.github/workflows/helm-kustomize-comparison.yml

I meant non-blocking for merges, not disabling them. The other option is that you update the helm chart for model registry 0.2.22 and create a PR against @tarilabs branch here.

@kunal-511
Copy link
Contributor

we can comment out this - 'applications/model-registry/**' and this - '.github/workflows/helm-kustomize-comparison.yml' from https://github.com/kubeflow/manifests/blob/ac32b09acd3afeaa2b9a16e3c0a8943f5ded2496/.github/workflows/helm-kustomize-comparison.yml

I meant non-blocking for merges, not disabling them. The other option is that you update the helm chart for model registry 0.2.22 and create a PR against @tarilabs branch here.

I have raised the PR against the @tarilabs branch to update helm charts values

@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Aug 19, 2025
@tarilabs
Copy link
Member Author

tarilabs commented Aug 19, 2025

I've accepted PR from @kunal-511 but I'm still confused if the process to update the manifest iwth the script must now also include Helm manifest changes.

@juliusvonkohout can you kindly advise.
ie

Can we make the helm tests non-blocking ?

I suppose we still will need to make the helm tests non-blocking (#3216 (comment))

@juliusvonkohout
Copy link
Member

I've accepted PR from @kunal-511 but I'm still confused if the process to update the manifest iwth the script must now also include Helm manifest changes.

@juliusvonkohout can you kindly advise. ie

Can we make the helm tests non-blocking ?

I suppose we still will need to make the helm tests non-blocking (#3216 (comment))

I think we have to make the Helm charts non-blocking or Kunal needs to extend the scripts for helm.

@juliusvonkohout
Copy link
Member

@kunal-511 also here as in all other PRs the CI/Cd is failing with training-operator.

@kunal-511
Copy link
Contributor

@kunal-511 also here as in all other PRs the CI/Cd is failing with training-operator.

Yes debugging it

tarilabs and others added 2 commits August 20, 2025 16:24
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout juliusvonkohout force-pushed the synchronize-kubeflow-model-registry-manifests-v0.2.22 branch from 2fa57cd to fd12f24 Compare August 20, 2025 14:25
@juliusvonkohout
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 805fe41 into kubeflow:master Aug 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants