-
Notifications
You must be signed in to change notification settings - Fork 1k
Limit Istio Sidecar Scope to reduce memory usage #3206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit Istio Sidecar Scope to reduce memory usage #3206
Conversation
|
/retest |
common/istio/istio-install/overlays/insecure/sidecar-prune-egress.yaml
Outdated
Show resolved
Hide resolved
|
/retest |
|
/retest |
|
@kunal-511 can you help investigating the test failure ? |
1d2b4f4 to
50debef
Compare
|
@kunal-511 @madmecodes this is from the gha logs and i see CrashLoopBackOff so probably something you need to debug locally. Also it should just wair for all pods in the users namespace, also the master, not just the worker. |
|
Istio injection is disabled for these pods, so that should be fine. You can also fork and test. |
…ore scalable Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
…ess.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
48daa9a to
1824662
Compare
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
related: kubeflow#3206 With the work to Limit Istio Sidecar Scope to reduce memory usage, the `kubeflow` namespace now needs to be present **prior** to the installation of Istio. While this actual work was already merged, a minor doc update was missed in the `Install Individual Components` section of the `README` - which had the `kubeflow` `namespace` getting installed much later in the process. Anyone following the doc would get an error about `kubeflow` `namespace` not existing while trying to install `Istio`. This PR simply moves the `namespace` install section prior to Istio. Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
* doc: fix ordering of individual install steps related: #3206 With the work to Limit Istio Sidecar Scope to reduce memory usage, the `kubeflow` namespace now needs to be present **prior** to the installation of Istio. While this actual work was already merged, a minor doc update was missed in the `Install Individual Components` section of the `README` - which had the `kubeflow` `namespace` getting installed much later in the process. Anyone following the doc would get an error about `kubeflow` `namespace` not existing while trying to install `Istio`. This PR simply moves the `namespace` install section prior to Istio. Signed-off-by: Andy Stoneberg <astonebe@redhat.com> * Update README.md Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Andy Stoneberg <astonebe@redhat.com> Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> Co-authored-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
✏️ Summary of Changes
Updated the old PR #3052 (Istio sidecar memory optimization) to work with current manifests structure:
Changes:
Benefits: (as discussed in #3052)
📦 Dependencies
#3052
✅ Contributor Checklist