-
Notifications
You must be signed in to change notification settings - Fork 1k
TrainJob support to Katib Trial Templates #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you, I will merge it once kubeflow/katib#2560 is merged |
/ok-to-test |
Hi |
@ram4444 Let's make sure this is merged in Katib project as part of your PR: kubeflow/katib#2560 |
/ok-to-test |
@ram4444 Please always rebase, never merge from master. This destroy the commit history. |
@kunal-511 can help with the failing tests. |
Yes I have raised the PR against @ram4444 branch to update helm charts |
@kunal-511 also here the same test is failing as in many other PRs. |
Signed-off-by: Ram Lau <ramwt4444@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
f15020a
to
814ffc9
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@juliusvonkohout @ram4444 I think, we still haven't fixed all of the issues in this PR to make TrainJob works with Katib. |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
Adding TrainJob support to Katib Trial Templates.
kubeflow/katib#2560
📦 Dependencies
🐛 Related Issues
✅ Contributor Checklist