Skip to content

Conversation

ram4444
Copy link
Contributor

@ram4444 ram4444 commented Jul 28, 2025

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Describe the changes you have made, including any refactoring or feature additions.

Adding TrainJob support to Katib Trial Templates.
kubeflow/katib#2560

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

Link any issues that are resolved or affected by this PR.

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout
Copy link
Member

Thank you, I will merge it once kubeflow/katib#2560 is merged

@juliusvonkohout
Copy link
Member

/ok-to-test

@ram4444
Copy link
Contributor Author

ram4444 commented Aug 4, 2025

Hi
Please let me know if I have to do anything to continue the progress

@andreyvelich
Copy link
Member

Hi Please let me know if I have to do anything to continue the progress

@ram4444 Let's make sure this is merged in Katib project as part of your PR: kubeflow/katib#2560

@juliusvonkohout
Copy link
Member

/ok-to-test

@juliusvonkohout
Copy link
Member

@ram4444 Please always rebase, never merge from master. This destroy the commit history.

@juliusvonkohout
Copy link
Member

@kunal-511 can help with the failing tests.

@kunal-511
Copy link
Contributor

@kunal-511 can help with the failing tests.

Yes I have raised the PR against @ram4444 branch to update helm charts

@juliusvonkohout
Copy link
Member

@kunal-511 also here the same test is failing as in many other PRs.

ram4444 and others added 2 commits August 20, 2025 16:26
Signed-off-by: Ram Lau <ramwt4444@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Aug 20, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit abba223 into kubeflow:master Aug 20, 2025
10 checks passed
@andreyvelich
Copy link
Member

@juliusvonkohout @ram4444 I think, we still haven't fixed all of the issues in this PR to make TrainJob works with Katib.
@ram4444 Can you take a look: kubeflow/katib#2560 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants