Skip to content

Helm charts Kserve Models Web App #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kunal-511
Copy link
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

  Helm Charts For Models Web app

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

Link any issues that are resolved or affected by this PR.

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout
Copy link
Member

probably it makes sense to now create subfolders in /tests for each component, but let me unblock you first
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- 'tests/models_web_app_compare_manifests.py'
- '.github/workflows/kserve-models-web-app-comparison.yml'
workflow_dispatch:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are the permissions for the gha ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added now

@juliusvonkohout
Copy link
Member

/hold

Copy link

New changes are detected. LGTM label has been removed.

@juliusvonkohout juliusvonkohout force-pushed the kserve-models-web-app-helm-charts branch from 9f52ee3 to 3c45668 Compare July 21, 2025 08:25
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jul 21, 2025

/hold

i think /tests is gettind crowded and there seems to be code duplication. Please check that there are not multiple scripts for the sme thing and also how we can reduce the number of files in /tests in general.
image For example we could merge PSS baseline and restricted or do other things, but we somehow need to reduce the amount of files to not lose the overview. We could also use subfolders, as we have them for kserve.

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511 kunal-511 force-pushed the kserve-models-web-app-helm-charts branch from 3c45668 to a0fcff1 Compare July 28, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants