Skip to content

Conversation

kunal-511
Copy link
Contributor

@kunal-511 kunal-511 commented Jun 20, 2025

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Helm Templates For Katib

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout
Copy link
Member

/hold

kunal-511 added 4 commits July 6, 2025 09:59
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Copy link
Contributor Author

@juliusvonkohout This is ready for review

@juliusvonkohout
Copy link
Member

also here lets start with subfolder in /tests soon
But to unblock you
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 18, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

/hold

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jul 18, 2025

The gha you added are missing proper security settings /permissions
Please also check the one for kserve models web application

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 18, 2025
@kunal-511
Copy link
Contributor Author

The gha you added are missing proper security settings /permissions Please also check the one for kserve models web application

added

@juliusvonkohout
Copy link
Member

/unhold
/lgtm
to unblock you.

But lets keep the priority we discussed regarding PRs.

@google-oss-prow google-oss-prow bot added the lgtm label Jul 21, 2025
@google-oss-prow google-oss-prow bot merged commit 8d28b57 into kubeflow:master Jul 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants