-
Notifications
You must be signed in to change notification settings - Fork 1k
Updated tests file naming scheme #3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
51d09b5
dad00de
0f2f87c
4e55b16
5d6c477
83d7a67
285a660
c3d2977
ce6cb63
1f0e291
a6be986
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,11 +2,11 @@ name: Test Admission Webhook | |
| on: | ||
| pull_request: | ||
| paths: | ||
| - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
| - tests/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
| - .github/workflows/admission_webhook_test.yaml | ||
| - apps/admission-webhook/upstream/** | ||
| - tests/gh-actions/install_istio*.sh | ||
| - tests/gh-actions/install_cert_manager.sh | ||
| - tests/istio-cni_install.sh | ||
| - tests/istio* | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line is missing in most workflows and should replace the line above |
||
| - common/cert-manager/** | ||
| - common/istio*/** | ||
|
|
||
|
|
@@ -18,13 +18,13 @@ jobs: | |
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install KinD, Create KinD cluster and Install kustomize | ||
| run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
| run: ./tests/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
|
|
||
| - name: Install Istio | ||
| run: ./tests/gh-actions/install_istio-cni.sh | ||
| run: ./tests/istio-cni_install.sh | ||
|
|
||
| - name: Install cert-manager | ||
| run: ./tests/gh-actions/install_cert_manager.sh | ||
| run: ./tests/cert_manager_install.sh | ||
|
|
||
| - name: Build & Apply manifests | ||
| run: | | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,10 @@ name: Test Central Dashboard | |
| on: | ||
| pull_request: | ||
| paths: | ||
| - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
| - tests/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
| - .github/workflows/centraldashboard_test.yaml | ||
| - apps/centraldashboard/upstream/** | ||
| - tests/gh-actions/install_istio*.sh | ||
| - tests/istio-cni_install.sh | ||
|
||
| - common/istio*/** | ||
|
|
||
| jobs: | ||
|
|
@@ -16,10 +16,10 @@ jobs: | |
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install KinD, Create KinD cluster and Install kustomize | ||
| run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
| run: ./tests/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
|
|
||
| - name: Install Istio | ||
| run: ./tests/gh-actions/install_istio-cni.sh | ||
| run: ./tests/istio-cni_install.sh | ||
|
|
||
| - name: Create kubeflow namespace | ||
| run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is now obsolete