-
Notifications
You must be signed in to change notification settings - Fork 960
Switch to Istio CNI by default #3135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@juliusvonkohout For GCP hostPath check,
am i suppose to spin the cluster in GCP/GKE ad check the paths? will that cost me? |
I know the paths and that it is correct for gcp. The question is how we can enable both cni directories at the same time. Since the default ones are correct for Azure, Kind and others. |
See #3061 (comment). We need to support both paths at the same time somehow. |
Okay, looking into this
|
Why This Multi-Path Approach woukd Work? The patch adds both the standard path (/opt/cni/bin) and the GCP-specific path (/home/kubernetes/bin) as separate volume mounts in the Istio CNI DaemonSet.
@juliusvonkohout what do you think, can this be a potential approach? |
Yes, could work. Do you mind testing it on GCP? I think there is a small free 4GB node available by default if you have a gmail adress. You jus tneed to install Istio, so it should be enough. I can then later also test on some GCP clusters. |
Do you mind fixing python3: can't open file '/home/runner/work/manifests/manifests/tests/gh-actions/test_pipeline.py': [Errno 2] No such file or directory in https://github.com/kubeflow/manifests/actions/runs/15084697684/job/42405783624?pr=3135 in a separate PR ? I think the file has just been renamed since we have v1 and v2 kfp tests. CC @kunal-511 to help |
@madmecodes The test_pipeline.py has been changed to test_pipeline_v2.py in #3129 |
this is updated #3136 |
… instead of standard Istio. Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
35a911b
to
83ac6c9
Compare
Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
Switch to Istio CNI by default
This PR changes the default Istio installation to use Istio CNI instead of standard Istio.
Key benefits include:
Changes include:
This change is part of the broader Rootless Kubeflow initiative #2528
and follows up on previous work #3061.