Skip to content

istio namespace missing #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025
Merged

istio namespace missing #3134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5e88a5
Update kustomization.yaml
juliusvonkohout May 16, 2025
e1fdda8
Update kustomization.yaml
juliusvonkohout May 16, 2025
11413aa
Update gateway.yaml
juliusvonkohout May 16, 2025
150137a
Update gateway.yaml
juliusvonkohout May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions common/istio-1-24/istio-install/base/gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: istio-ingressgateway
namespace: istio-system
labels:
release: istio
spec:
Expand Down
1 change: 1 addition & 0 deletions common/istio-cni-1-24/istio-install/base/gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: istio-ingressgateway
namespace: istio-system
labels:
release: istio
spec:
Expand Down
2 changes: 2 additions & 0 deletions common/istio-cni-1-24/istio-install/base/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

#namespace: istio-system # this does not work, because the istio-cni daemonset should be in kube-system

Check warning on line 4 in common/istio-cni-1-24/istio-install/base/kustomization.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

4:2 [comments] missing starting space in comment

resources:
- install.yaml
- gateway_authorizationpolicy.yaml
Expand Down
Loading