Skip to content

Migrate to gateway api #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

akagami-harsh
Copy link
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

  • added gateway api crds
  • modified synchronize scripts to gateway api crds
  • Updated Gateway definitions in kf-istio-resources.yaml and gateway.yaml to use Gateway API format

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

✅ Contributor Checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

Please cross check with the istio ambient issue to get useful architecture information.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Apr 14, 2025

This one #2676
CC also @kimwnasptd

@juliusvonkohout
Copy link
Member

juliusvonkohout commented May 11, 2025

@akagami-harsh please rebase to master. We should also try to unify istio and istio-cni such that there is less code duplication @madmecodes. Maybe you can work together here.

@juliusvonkohout juliusvonkohout added this to the 1.11 milestone May 11, 2025
@madmecodes
Copy link
Contributor

Okay, i will collaborate with @akagami-harsh

@akagami-harsh akagami-harsh force-pushed the gateway-api branch 2 times, most recently from 75c8f47 to b028e63 Compare June 11, 2025 10:23
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jun 11, 2025

Please do a proper rebase to master. It should only change the files necessary for the PR with the minimal amount of commits.

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@juliusvonkohout
Copy link
Member

Do you mind squashing your 26 commits ?

@juliusvonkohout
Copy link
Member

And to clarify, kubeflow/pipelines#11965 has a higher priority

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@akagami-harsh akagami-harsh force-pushed the gateway-api branch 3 times, most recently from ba208e9 to 68e9590 Compare June 13, 2025 22:50
@akagami-harsh
Copy link
Contributor Author

Do you mind squashing your 26 commits ?

I'll squash the commits once the PR is ready for final review.

And to clarify, kubeflow/pipelines#11965 has a higher priority

Got it — I'll shift my focus to the SeaweedFS PR and pause work on this one for now, it still needs further refinement.

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants